Skip to content

[BEAM-22] Implement InProcessEvaluationContext - #11

Closed
tgroh wants to merge 1 commit into
apache:masterfrom
tgroh:ippr_evaluation_context
Closed

[BEAM-22] Implement InProcessEvaluationContext#11
tgroh wants to merge 1 commit into
apache:masterfrom
tgroh:ippr_evaluation_context

Conversation

@tgroh

@tgrohtgroh commented Mar 2, 2016

Copy link
Copy Markdown
Member

This is the primary "global state" object for the evaluation of a
Pipeline using the InProcessPipelineRunner, and is responsible for
properly routing information about the state of the pipeline to
transform evaluators.

Remove the InProcessEvaluationContext from the InProcessPipelineRunner
class, and implement as a class directly. Fix associated imports.

Split from the first commit in #3

@tgroh

tgroh commented Mar 2, 2016

Copy link
Copy Markdown
MemberAuthor

R: @kennknowles

import javax.annotation.Nullable;

/**
* The evaluation context for the {@link InProcessPipelineRunner}. Contains state shared within

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is for a specific pipeline running in the InProcessPipelineRunner, right? Maybe say
"The evaluation context for a specific pipeline running in the {@link InProcessPipelineRunner}."

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tgroh
tgrohforce-pushed the ippr_evaluation_context branch from 87b4c55 to 2635f86CompareMarch 12, 2016 00:53
This is the primary "global state" object for the evaluation of a
Pipeline using the InProcessPipelineRunner, and is responsible for
properly routing information about the state of the pipeline to
transform evaluators.
Remove the InProcessEvaluationContext from the InProcessPipelineRunner
class, and implement as a class directly. Fix associated imports.
@tgroh
tgrohforce-pushed the ippr_evaluation_context branch from 75e6168 to 1e76244CompareMarch 12, 2016 01:23
@dhalperi

Copy link
Copy Markdown
Contributor

@bjchambers did you LGTM this? I cannot find.

@dhalperi

Copy link
Copy Markdown
Contributor

Okay @tgroh claims it's tgroh@2635f86#commitcomment-16659043

@tgroh
tgroh deleted the ippr_evaluation_context branch March 15, 2016 21:26
davorbonaci added a commit to GoogleCloudPlatform/DataflowJavaSDK that referenced this pull request Mar 25, 2016
cosmoskitten pushed a commit to cosmoskitten/beam that referenced this pull request Apr 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tgroh@dhalperi@bjchambers