Skip to content

[BEAM-168] IntervalBoundedExponentialBackOff: add deprecated copy of old API#117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalperi wants to merge 1 commit into from
Closed

[BEAM-168] IntervalBoundedExponentialBackOff: add deprecated copy of old API #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...e/src/main/java/com/google/cloud/dataflow/sdk/util/IntervalBoundedExponentialBackOff.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,12 @@ public class IntervalBoundedExponentialBackOff implements BackOff {
private final long initialIntervalMillis;
private int currentAttempt;

// BEAM-168: https://issues.apache.org/jira/browse/BEAM-168
@Deprecated

@bjchambersbjchambersApr 4, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment about why this is around and deprecated?

@dhalperidhalperiApr 4, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

public IntervalBoundedExponentialBackOff(int maximumIntervalMillis, long initialIntervalMillis) {
this((long) maximumIntervalMillis, initialIntervalMillis);
}

public IntervalBoundedExponentialBackOff(long maximumIntervalMillis, long initialIntervalMillis) {
Preconditions.checkArgument(
maximumIntervalMillis > 0, "Maximum interval must be greater than zero.");
Expand Down