Skip to content

[BEAM-10185] Build python wheels on GitHub Actions for Windows [dependent on BEAM-10184] - #11968

Closed
TobKed wants to merge 4 commits into
apache:masterfrom
TobKed:github-actions-build-wheels-windows
Closed

[BEAM-10185] Build python wheels on GitHub Actions for Windows [dependent on BEAM-10184]#11968
TobKed wants to merge 4 commits into
apache:masterfrom
TobKed:github-actions-build-wheels-windows

Conversation

@TobKed

Copy link
Copy Markdown
Contributor

dependent on #11877
Subtask of BEAM-9388

Example GitHub Action runs available on my fork: https://github.com/TobKed/beam/actions?query=branch%3Agithub-actions-build-wheels-windows


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKApexDataflowFlinkGearpumpSamzaSpark
GoBuild Status------Build Status------Build Status
JavaBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
---Build Status
Build Status
Build Status
Build Status
Build Status
------Build Status
XLang---------Build Status------Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TobKed
TobKedforce-pushed the github-actions-build-wheels-windows branch from e610f9c to 671498eCompareJune 10, 2020 14:45
@TobKed

Copy link
Copy Markdown
ContributorAuthor

Hi @robertwb, I've found your are Cython specialist. Could you take a quick look on this draft please?
There is a problem with c libraries on windows and I don't know how to solve it.
The only problematic file is sdks/python/apache_beam/runners/worker/statesampler_fast.pyx, if I ignore it then build will finish successfully. The first problem is with unistd.h, after some ugly workarounds for unistd.h i got problems with methods from time.h.
I would appreciate any suggestions.

@TobKed
TobKedforce-pushed the github-actions-build-wheels-windows branch from 671498e to d655937CompareJune 30, 2020 08:30
@TobKed
TobKedforce-pushed the github-actions-build-wheels-windows branch from d9c092a to be55d6eCompareJune 30, 2020 09:39
@TobKed

Copy link
Copy Markdown
ContributorAuthor

@damgad since you have some significant progress in building python wheels on wndows I am closing this PR and waiting for yours

@TobKedTobKed closed this Jul 3, 2020
@robertwb

Copy link
Copy Markdown
Contributor

We've been avoiding doing any cythonization at all on Windows due to issues like this due to statesampler_fast using (unavailable on Windows) posix APIs. It may be possible to skip just this file, rather than everything, on Windows.

@damgad

Copy link
Copy Markdown
Contributor

@robertwb I've already written windows versions for the missing posix functions. Please take a look @robertwb#12172

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TobKed@robertwb@damgad