Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10399] Periodic clear of GCS wheels staging bucket - #12049
Conversation
4bdb4dd to
5e579bbCompare5e579bb to
ee4916cCompare| service_account_key: ${{ secrets.GCP_SA_KEY }} | ||
| - name: Delete folders without corresponding branch in repo | ||
| run: | | ||
| declare -a FOLDERS_TO_BE_DELETED=() |
There was a problem hiding this comment.
I think it's much better to put it all in separate bash script and call it from there. It's easier to analyse it this way
There was a problem hiding this comment.
I agree. The bash script contained in the YAML file cannot be validated by shellcheck.
There was a problem hiding this comment.
Thanks for the suggestion. I moved it to the separate file. Looks much more nicer and it is easier do test script locally.
TobKed
commented
Jul 8, 2020
What files will be cleared this way? Release branches live forever. Would there be other branches that this script will clean? |
TobKed
commented
Jul 13, 2020
At the moment only master and release branches upload wheels to GCS. and after learning that release branches are kept forever this PR seems has no sense. |
Once per month clear GCS folders which do not have corresponding branches.
#11877 (comment)
#11877 (comment)
Before merging
Before merging it is required to setup related secrets:
GCP_PROJECT_IDThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.