Skip to content

[BEAM-10465] Add checksum for Python source distribution and wheels - #12233

Merged
aaltay merged 1 commit into
apache:masterfrom
TobKed:BEAM-10465-checksum-py-source-dist-wheels
Jul 14, 2020
Merged

[BEAM-10465] Add checksum for Python source distribution and wheels#12233
aaltay merged 1 commit into
apache:masterfrom
TobKed:BEAM-10465-checksum-py-source-dist-wheels

Conversation

@TobKed

@TobKedTobKed commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Add sha512sum for later verification.

test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLang------Build Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TobKed

TobKed commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@aaltay

Copy link
Copy Markdown
Member

Do we expect workflows to run when there is a change to workflows?

@TobKed

TobKed commented Jul 14, 2020

Copy link
Copy Markdown
ContributorAuthor

I am not sure did I understand your question @aaltay .
Updated workflow will run after merging it to the master.
Since workflows are run only when they merged to master it is not possible to verify them before merging. I think a good practice is to put the link to the example run executed on the fork.

Here is the test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085

@aaltay

Copy link
Copy Markdown
Member

I am not sure did I understand your question @aaltay .
Updated workflow will run after merging it to the master.
Since workflows are run only when they merged to master it is not possible to verify them before merging. I think a good practice is to put the link to the example run executed on the fork.

Here is the test on my fork:
https://github.com/TobKed/beam/actions/runs/161961085

OK. This kind of answers my question. I was asking because:

  • we are able to run workflows on PRs
  • And changing the workflow code should be tested by running the workflow code.

And based on the other PR, it seems like not everyone will be able to run the workflow on their repo. (e.g. they might be missing GCS parts.)

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

@aaltay

Copy link
Copy Markdown
Member

I will merge this, I do not want to block the PR. Please respond to my question when you get a chance.

@aaltay
aaltay merged commit c946886 into apache:masterJul 14, 2020
@TobKed

Copy link
Copy Markdown
ContributorAuthor

@aaltay thanks for merging :)

Actually I was wrong with statement: "workflows are run only when they merged to master".
It is possible to run workflows not merged to master e.g. in PR which introduces new workflow and it is triggered on 'push' event type this new workflow will run.

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

It is possible to include '.github/workflows/**' in paths:
https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L30
Then any change in this dir in PR will trigger Build python wheels workflow run.
Do you think I should create PR with this change?

@aaltay

Copy link
Copy Markdown
Member

@aaltay thanks for merging :)

Actually I was wrong with statement: "workflows are run only when they merged to master".
It is possible to run workflows not merged to master e.g. in PR which introduces new workflow and it is triggered on 'push' event type this new workflow will run.

My specific question, is it possible to trigger workflow similar to PR workflows if changes touch the workflow files?

It is possible to include '.github/workflows/**' in paths:
https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L30
Then any change in this dir in PR will trigger Build python wheels workflow run.
Do you think I should create PR with this change?

Yes, I think it would be good to create that PR and test workflows when the workflow files change.

@TobKed

Copy link
Copy Markdown
ContributorAuthor

Sorry for late response. I created PR with basic documentation for GItHub Actions CI #12405

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TobKed@aaltay