Skip to content

[BEAM-7390] Add combinevalues code snippets - #12328

Merged
aaltay merged 4 commits into
apache:masterfrom
davidcavazos:combinevalues-docs
Jul 23, 2020
Merged

[BEAM-7390] Add combinevalues code snippets#12328
aaltay merged 4 commits into
apache:masterfrom
davidcavazos:combinevalues-docs

Conversation

@davidcavazos

@davidcavazosdavidcavazos commented Jul 21, 2020

Copy link
Copy Markdown

Add CombineValues code snippets.

R: @aaltay
R: @rosetn

Staged: http://apache-beam-website-pull-requests.storage.googleapis.com/12328/documentation/transforms/python/aggregation/combinevalues/index.html


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild Status---Build Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay

Copy link
Copy Markdown
Member

LGTM. I can merge after @rosetn gets a chance to review. Please ping me after that.

@rosetn

rosetn commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

I think you might have embedded the wrong code sample for example 1--you're using saturated_sum instead of just sum and the output is the result of sum

@davidcavazos

Copy link
Copy Markdown
Author

I think you might have embedded the wrong code sample for example 1--you're using saturated_sum instead of just sum and the output is the result of sum

Thank you for catching this!

@aaltay

Copy link
Copy Markdown
Member

Is this ready to be merged now? Seems like the snippet issue is fixed.

@rosetnrosetn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @aaltay ready to merge.

@aaltay
aaltay merged commit 13f9e89 into apache:masterJul 23, 2020
@davidcavazos
davidcavazos deleted the combinevalues-docs branch July 23, 2020 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@davidcavazos@aaltay@rosetn