Skip to content

[BEAM-7996] Add map & nil encoding to Go SDK. - #12467

Merged
lostluck merged 1 commit into
apache:masterfrom
lostluck:beam9615map
Aug 5, 2020
Merged

[BEAM-7996] Add map & nil encoding to Go SDK.#12467
lostluck merged 1 commit into
apache:masterfrom
lostluck:beam9615map

Conversation

@lostluck

@lostlucklostluck commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Adds the Beam Schema map coding and container nil handling to the Go SDK, per #12426.
While independent, this should probably not merge until that PR is finalized.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild Status---Build Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsite
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild Status
Portable---Build Status------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels

See CI.md for more information about GitHub Actions CI.

@lostluck

Copy link
Copy Markdown
ContributorAuthor

R: @youngoli
cc: @TheNeuralBit

@lostluck
lostluck requested a review from youngoliAugust 4, 2020 23:07

@youngoliyoungoli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lostluck
lostluck merged commit b1fff0a into apache:masterAug 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lostluck@youngoli