Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10647] Fixes get_query_location bug in BigQueryWrapper - #12480
Conversation
5fca0c3 to
1f8f392Comparegaluszkak
commented
Aug 6, 2020
1f8f392 to
dfdcd2eCompare
apilloud
left a comment
There was a problem hiding this comment.
LGTM, but I'm not familiar with Python style, particularly around optional imports, so I'll defer to @pabloem on this.
I believe we recently received a report of this problem on the Java SDK as well. It might be nice to have a integration test, as it is possible this behavior changed on BigQuery. Thanks for taking the time to track it down!
cc: @chamikaramj
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dfdcd2e to
c31d2e1Compareapilloud
commented
Aug 6, 2020
Jenkins is having issues right now (see https://issues.apache.org/jira/browse/INFRA-20649) but will merge this when it is fixed. Please remind me if I forget! |
galuszkak
commented
Aug 7, 2020
@apilloud I think Jenkins is fixed. Thanks! |
galuszkak
commented
Aug 7, 2020
apilloud
commented
Aug 7, 2020
Thanks. The other failure is BEAM-8912. |
pabloem
commented
Aug 7, 2020
thanks - this looks great fwiw : ) |
This enables to look for location in BigQueryWrapper for first available referenced table for the user. If you are querying authorised view, you may end up with permission error of accessing referenced table that is in authorised view and be unable to retrieve location, so you should look on next available table for You that you should have permission.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.