Uh oh!
There was an error while loading. Please reload this page.
[BEAM-9179] Move value conversion logic out of ExpressionConverter - #12507
Merged
Conversation
robinyqiuforce-pushed
the
refactor
branch
4 times, most recently
from
August 8, 2020 04:42
2bcc21c to
51a54e6Compareapilloud
approved these changes
Aug 10, 2020
| String name = fields.get(i).getName(); | ||
| if ("".equals(name)) { | ||
| name = "$col" + i; | ||
| name = "$col" + i; // empty field name is not allowed, generate an index-based name for it |
Member
There was a problem hiding this comment.
I believe a single column with an empty name is allowed. ZetaSQL allows multiple columns without names.
ContributorAuthor
There was a problem hiding this comment.
Yeah this comment is not accurate. The real problem is Beam does not allow multiple columns with the same name (empty in this case). Thanks for spotting this.
robinyqiu
commented
Aug 10, 2020
ContributorAuthor
cc: @ZijieSong946 This recent refactor caused a merge conflict for your WIP TIMESTAMP PR. |
ZijieSong946
commented
Aug 10, 2020
Contributor
Ack. |
robinyqiu
commented
Aug 12, 2020
| private static RexNode structValueToRexNode(Value value, RexBuilder rexBuilder) { | ||
| return rexBuilder.makeCall( | ||
| toCalciteStructType(value.getType().asStruct(), false, rexBuilder), |
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Simplification] Type translation code refactor:
r: @apilloud
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.