Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10677] Fix @SchemaFieldName in AutoValueSchema - #12520
Merged
TheNeuralBit merged 2 commits intoSep 30, 2020
Conversation
| // Verify that constructor parameters match (name and type) the inferred schema. | ||
| for (Parameter parameter : constructor.getParameters()) { | ||
| FieldValueTypeInformation type = typeMap.getOrDefault(parameter.getName(), null); | ||
| if (type == null || type.getRawType() != parameter.getType()) { |
MemberAuthor
There was a problem hiding this comment.
I'm not quite sure what the old logic was trying to verify. Now this verifies that every constructor parameter corresponds to a schema field.
Contributor
There was a problem hiding this comment.
I believe the getterTypes is the list of schema name, where typeMap is the attribute name from AutoValue class. It's trying to verify whether the schema matches the AutoValue class since it wants to get a constructor.
4 tasks
TheNeuralBit
commented
Aug 11, 2020
MemberAuthor
Run Python 3.8 PostCommit |
TheNeuralBit
commented
Sep 10, 2020
MemberAuthor
retest this please |
TheNeuralBit
commented
Sep 10, 2020
MemberAuthor
Run Python 3.8 PostCommit |
TheNeuralBit
commented
Sep 10, 2020
MemberAuthor
R: @kennknowles do you have time to take a look at this? |
kennknowles
self-requested a review
September 10, 2020 23:13
kennknowles
approved these changes
Sep 28, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.