Uh oh!
There was an error while loading. Please reload this page.
[BEAM-7705] Update BigQuery docs with new code snippets - #12559
Conversation
rosetn
left a comment
There was a problem hiding this comment.
Yes! Thank you for working on these updates! 🙏
LGTM
meredithslota
commented
Aug 24, 2020
@chamikaramj Do you have a moment to take a look at these? Thank you! :) |
| {{< highlight java >}} | ||
| {{< code_sample "examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java" BigQueryDataTypes >}} | ||
| {{< code_sample "examples/java/src/main/java/org/apache/beam/examples/snippets/transforms/io/gcp/bigquery/BigQueryTableRowCreate.java" bigquery_table_row_create >}} |
There was a problem hiding this comment.
Did you intend to use underscore separated text (not camel case) for Java ?
There was a problem hiding this comment.
We usually do region tags in snake_case for all languages regardless of the language style. The reason is that by keeping them consistent through all languages, it's easier to build tools to parse them and compare between which snippets exist for each language.
chamikaramj
left a comment
There was a problem hiding this comment.
LGTM other than one comment. Thanks.
davidcavazos
commented
Sep 1, 2020
@aaltay all tests are passing and we have an approval. Is this ready to merge? |
Updating the BigQuery docs to use the new code snippets from #12118
R: @rosetn
R: @aaltay
Staged: http://apache-beam-website-pull-requests.storage.googleapis.com/12559/documentation/io/built-in/google-bigquery/index.html
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.