Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10702, BEAM-10757] Cherrypick #12571: Do not implicitly decompress artifacts - #12619
Conversation
Also adds a Julia set test on portable local runner, which uses a setup.py and hence exercises the artifact staging codepath. This is a squashed cherrypick of #12571
jkff
commented
Aug 18, 2020
Hmm all the builds are pending apparently cause something's going on with Jenkins - eg https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/ says "Jenkins is going to shut down". Haven't seen this before. Do I need to do anything? |
tvalentyn
commented
Aug 18, 2020
not sure, perhaps related to https://issues.apache.org/jira/browse/BEAM-10751. |
tvalentyn
commented
Aug 18, 2020
retest this please |
youngoli
left a comment
There was a problem hiding this comment.
This all looks good, thanks Eugene! I'll merge it in after the tests pass, assuming the Python Precommit issue is fixed.
@youngoli note that precommit IT tests will fail until Dataflow containers for the release branch are built. This change does not affect Dataflow codepath. |
jkff
commented
Aug 18, 2020
retest this please |
jkff
commented
Aug 18, 2020
Retesting cause https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/12849/consoleFull shows an error in |
tvalentyn
commented
Aug 18, 2020
Run PythonDocker PreCommit |
tvalentyn
commented
Aug 18, 2020
We would need to change how we fetch the license for enum34. This must be blocking precommits now on master as well. |
tvalentyn
commented
Aug 18, 2020
@ethanfurman FYI, the project homepage link (https://bitbucket.org/stoneleaf/enum34) at https://pypi.org/project/enum34/ is now broken. |
jkff
commented
Aug 18, 2020
Yeah it'll have to be added to manual_licenses. I'll do that in this PR in a moment. |
tvalentyn
commented
Aug 18, 2020
tvalentyn
commented
Aug 18, 2020
thanks, @jkff, will assign that to you then. |
There was a problem hiding this comment.
did you git add the LICENSE file? Also, it would be great if you send a PR for master with these commit(s). Thanks!
There was a problem hiding this comment.
Oops, added now, thanks! Will send a separate PR to master. Do you prefer if I remove it from here?
There was a problem hiding this comment.
Feel free to keep it here as well, we can merge these into 2.24.0 as two separate commits. Thanks!
jkff
commented
Aug 19, 2020
The PythonDocs precommit is failing because it was only added at master in #12575 and isn't present in the 2.24 branch. |
youngoli
commented
Aug 19, 2020
Ack. The Python Precommit is also only failing because of BEAM-10697, so that's not an issue. I'm wondering about the PVR_Flink PreCommit though, I haven't seen that error below. Flake maybe? (Link) |
youngoli
commented
Aug 19, 2020
Run Python2_PVR_Flink PreCommit |
Alright, we now have 2 failing precommits both due to known issues: Python with BEAM-10697, and PythonDocs because it doesn't exist at 2.24. Looks like BEAM-10697 is resolved, but not cherrypicked into 2.24. @youngoli Do you want to ignore it for this PR or should we wait for someone to cherrypick a fix and rebase on that? |
youngoli
commented
Aug 19, 2020
Yeah, I think it's safe to ignore the Python precommit error here. I'll merge it in. |
Also adds a Julia set test on portable local runner, which uses a
setup.py and hence exercises the artifact staging codepath.
This is a squashed cherrypick of #12571 + a change to CHANGES.md.
I also added the LICENSE for enum34 to manual_licenses as the original repo is down. I took the license from somebody's backup: https://github.com/jamespharaoh/python-enum34
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.