Skip to content

[BEAM-10602] Fix display of latency and checkpoint duration metrics - #12717

Merged
kamilwu merged 1 commit into
apache:masterfrom
mxm:BEAM-10602
Aug 31, 2020
Merged

[BEAM-10602] Fix display of latency and checkpoint duration metrics#12717
kamilwu merged 1 commit into
apache:masterfrom
mxm:BEAM-10602

Conversation

@mxm

@mxmmxm commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

This fixes the labels for the latency and checkpoint panels. Instead of
displaying "$tag_metric" as the name, it now displays the metric name,
e.g. 'python_streaming_pardo_6.max'.
ibution quickly and easily:

Before:

image

After:

image

Also adjusts the titles of the two affected panels.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild Status---Build Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespace
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild Status
Portable---Build Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This fixes the labels for the latency and checkpoint panels. Instead of
displaying "$tag_metric" as the name, it now displays the metric name,
e.g. 'python_streaming_pardo_6.max'.
Also adjusts the titles of the two affected panels.

@kamilwukamilwu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@kamilwu
kamilwu merged commit 12711bb into apache:masterAug 31, 2020
@mxm

mxm commented Aug 31, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks @kamilwu!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mxm@kamilwu