Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10670] Improve messaging in CHANGES.md giving clearer instructions to users. - #13015
Merged
Conversation
lukecwik
commented
Oct 5, 2020
MemberAuthor
R: @robinyqiu CC: @kennknowles |
| ## Highlights | ||
| * Splittable DoFn is opt-out for Java based runners (Direct, Flink, Jet, Samza, Twister2)using `--experiments=use_deprecated_read`. For all other runners, users can opt-in using `--experiments=use_sdf_read`. (Java) ([BEAM-10670](https://issues.apache.org/jira/browse/BEAM-10670)) | ||
| * Splittable DoFn is now the default for executing the Read transform for Java based runners (Direct, Flink, Jet, Samza, Twister2). Users can opt-out using `--experiments=use_deprecated_read`. The Apache Beam community is looking for feedback for this change as the community is planning to make this change permanent with no opt-out. If you run into an issue requiring the opt-out, please send an e-mail to [user@beam.apache.org](mailto:user@beam.apache.org) specifically referencing BEAM-10670 in the subject line and why you needed to opt-out. (Java) ([BEAM-10670](https://issues.apache.org/jira/browse/BEAM-10670)) |
Member
There was a problem hiding this comment.
It is worth emphasizing that the expected result of a Read transform is unchanged, otherwise users might wonder if this change will alter their pipeline's semantics.
kennknowles
self-requested a review
October 6, 2020 16:41
robinyqiu
approved these changes
Oct 6, 2020
robinyqiu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Does this change need to be cherry-picked into the release branch?
lukecwik
commented
Oct 6, 2020
MemberAuthor
@robinyqiu For posterity it would make sense even though this change won't impact the built artifacts. |
4 tasks
robinyqiu pushed a commit
that referenced
this pull request
Oct 6, 2020
[BEAM-10670] Cherrypick #13015 to 2.25.0: "[BEAM-10670] Improve messaging in CHANGES.md giving clearer instructions to users."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.