Uh oh!
There was an error while loading. Please reload this page.
[BEAM-9444] Use GCP BOM to set package versions - #13075
Conversation
kileys
commented
Oct 12, 2020
Run Java examples on Dataflow Java 11 |
kileys
commented
Oct 12, 2020
Run Dataflow ValidatesRunner Java 11 |
kileys
commented
Oct 12, 2020
Run Dataflow ValidatesRunner |
kileys
commented
Oct 12, 2020
Run Java PostCommit |
The Build Workflow run is cancelling this PR. It in earlier duplicate of 2173354 run. |
kennknowles
commented
Oct 12, 2020
Run Spotless PreCommit |
kennknowles
commented
Oct 12, 2020
I don't see any reason for that strange error in spotless. |
kileys
commented
Oct 13, 2020
Run Python PreCommit |
kileys
commented
Oct 13, 2020
Run Python_PVR_Flink PreCommit |
kileys
commented
Oct 15, 2020
Run Spark ValidatesRunner |
kileys
commented
Oct 15, 2020
Run Dataflow ValidatesRunner |
kileys
commented
Oct 15, 2020
@suztomo are there other tests I should run to verify this? Linkage checker runs without any new errors |
kileys
commented
Oct 15, 2020
kileys
commented
Oct 15, 2020
The Dataflow validates runner tests are also failing on master |
suztomo
left a comment
There was a problem hiding this comment.
are there other tests I should run to verify this?
Not that I know of.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lukecwik
commented
Oct 19, 2020
Also, it seems as though existing modules that don't add a platform level dep to the GCP libraries bom will get some version of the dep since we have cleared the version. |
kileys
commented
Oct 30, 2020
Run Java PreCommit |
kileys
commented
Oct 30, 2020
Run Python PreCommit |
kileys
commented
Oct 30, 2020
Run Java_Examples_Dataflow PreCommit |
kennknowles
commented
Nov 2, 2020
It does seem that if a module had any of these deps but forgot the Here's what I did to view the dep changes: |
kennknowles
left a comment
There was a problem hiding this comment.
I do not have the capacity to manually determine the possible consequences of the dep changes, which do affect modules not listed (for example autovalue annotations are downgraded a couple patch versions).
I was checking just for modules that were accidentally "upgraded" to the latest by not having a version or that were accidentally downgraded because the BOM reduced versions they depended on that had nothing to do with GCP. I did not find any problems, but it is too much content to be certain. Still, it is surely an improvement.
Use GCP libraries bom to set versions for GCP related libraries
Updated version of #11156
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.