Uh oh!
There was an error while loading. Please reload this page.
[BEAM-11182][Website revamp] Implemented Stay up to date with Beam and Changed Works with components - #13406
Conversation
1b9f697 to
8f6802cComparebntnam
commented
Nov 23, 2020
Review: @TheNeuralBit |
TheNeuralBit
left a comment
There was a problem hiding this comment.
Could you add TODOs around text that's just a placeholder demonstrating the design? That way we won't forgot to swap it out before merging to master
There was a problem hiding this comment.
In the future, will this data be pulled from recent blog posts, or will we have to keep it up to date?
There was a problem hiding this comment.
Great that you asked. Yeah, in the future, we'll have a separate stage for functionality improvement (the current stage is about design implementation). And the event will be synced with the event page (which will be implemented later).
There was a problem hiding this comment.
What is the difference between files like this (i18n/**/en.yaml), and the miscellaneous en directories in data? AFAICT the difference is just that i18n just has simpler id - translation pairs while the config in data can be more complex and structured.
Based on that distinction it seems like much of this would be more appropriate in data
There was a problem hiding this comment.
Yeah. What I understand is, i18n directory is naturally offered by the Hugo plugin with the same name and it's used for localizing strings, syntax {{ i18n "id here" }} or {{ T "id here" }}. First, I got stuck when I needed to use a loop structure, plus translation together. Then I figured out that data let me to apply a loop structure on it as an array, and i18n helped me to separate directories according to the main language (data/en, data/pl, data/sp, etc.). I know it's a bit annoying to have 2 places, but simply think that one for strings and one for arrays. 😛
There was a problem hiding this comment.
Gotcha. It seems like with that pattern home-calendar* items could be represented in data with a structure like:
home-calendar-first:
- category-tag: "Category"
- category-date: "2020/02/21"
- card-title: "Performance-Driven Runtime Type Checking for the Python SDK"
- card-author: "Saavan Nanavati"
d2abcfb to
08e64f3Compare59f91a8 to
afcd0f5Compareafcd0f5 to
43555beComparebntnam
commented
Nov 24, 2020
Added comments and resolved conflicts |
TheNeuralBit
left a comment
There was a problem hiding this comment.
Couple more questions, but they don't need to block merging
There was a problem hiding this comment.
Gotcha. It seems like with that pattern home-calendar* items could be represented in data with a structure like:
home-calendar-first:
- category-tag: "Category"
- category-date: "2020/02/21"
- card-title: "Performance-Driven Runtime Type Checking for the Python SDK"
- card-author: "Saavan Nanavati"
| url: # | ||
| - title: This is the title | ||
| place: Data Con LA | ||
| time: 2020/02/21 |
There was a problem hiding this comment.
Is it possible for the dates to be represented as some kind of timestamp literal that can be internationalized? For example in the US we usually write dates with the year last - 02/21/2020. Or we may want to have the option to spell out the date in the future.
There was a problem hiding this comment.
Noted. Thanks for your feedback. Let me tell my PM to add them into Jira.
Home page:
Note: Copies/Texts will be updated later by Gris or the community. For now, it's just the implementation of the design.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.