[BEAM-11424-11423-11368][Website revamp] Implemented contribution guide, become a committer pages and twitter feed by Jakub-Sadowski · Pull Request #13565 · apache/beam

Jakub-Sadowski · 2020-12-16T10:47:11Z

Implemented:

contribution guide page
become a committer page
twitter feed component

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	Dataflow	Samza	Twister2
Go	---	---	---
Java
Python		---	---
XLang		---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---		---	---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

…eaInternal/beam into website/contribute-twitter

Jakub-Sadowski · 2020-12-16T11:44:01Z

Review: @TheNeuralBit

pabloem · 2020-12-17T17:33:41Z

thank you @Jakub-Sadowski ! Can you share a few screenshots of these changes?

TheNeuralBit · 2020-12-17T18:52:19Z

You can see it in the GCS staged output: http://apache-beam-website-pull-requests.storage.googleapis.com/13565/contribute/become-a-committer/index.html

pabloem · 2020-12-17T20:42:52Z

ouch - thanks Brian!

TheNeuralBit · 2020-12-17T21:46:44Z

No worries :) I can still review this one if that's ok with you, I'll have time this afternoon

pabloem · 2020-12-17T21:51:53Z

Sounds good. I'll leave it to you - but let me know if you'd like me to review it.

…

On Thu, Dec 17, 2020 at 1:47 PM Brian Hulette ***@***.***> wrote: No worries :) I can still review this one if that's ok with you, I'll have time this afternoon — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#13565 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ5Z3EEL5E6DIA2RS2BWDDSVJ35FANCNFSM4U5YXXCA> .

TheNeuralBit

I'm concerned that this makes a lot of changes to the actual markdown content, like website/www/site/content/en/contribute/become-a-committer.md and website/www/site/content/en/contribute/_index.md

These are exactly the sort of changes we're trying to avoid making as part of the website revamp because they're impossible to deconflict with any website updates that happen in parallel in master.

In general this PR has two types of changes in these content files:

Changes just to make the page render correctly (e.g. adding <div> and <br> tags)
Changes to the actual content (re-wording or re-arranging text)

We should try very hard to avoid (1), and keep the content separate from the template that renders it.

(2) should be done on the master branch, with the existing website.

If we adhere to both of those, there won't be the need to make markdown changes in the website-revamp branch

Jakub-Sadowski · 2020-12-28T10:19:17Z

Review: @kgabryje

TheNeuralBit

I just synced master into the website-revamp branch and there's now a conflict with contribute/_index.md. This is probably because of #13420 which made substantial changes to that file.

TheNeuralBit

This PR makes a lot of seemingly unnecessary changes to existing content files (blog posts, documentation, and programming guide). Some of them are benign, like changing ``` to {{< highlight >}}, but there also substantive ones like removing leading whitespace from code samples.

Even the benign ones present an issue, because they are surely going to cause merge conflicts, and they make this into an 8k line PR, which is very difficult to review. Please revert these changes.

TheNeuralBit

A few more notes here, but again, I haven't looked it all over yet because It's very challenging to review just the substantive changes amid all the changes to the code blocks.

TheNeuralBit

Thanks it looks like a lot of the extra changes have been reverted, but there are still a lot remaining. It would be great if we could keep the original {{< highlight lang >}} syntax and avoid having to change the existing content altogether.

Jakub-Sadowski

done

TheNeuralBit

Ok a few last comments here. I think this is ready to go if we get all these addressed.

TheNeuralBit · 2021-02-04T18:46:43Z

+ el.value=text;document.body.appendChild(el);
+ el.select();document.execCommand('copy');
+ document.body.removeChild(el);
+ alert('copied to clipboard');


This alert is strange to me. It's weird to have to click "OK" after copying.
Other implementations of this sort of featureu usually pop up a notification to let you know the content has been copied, but you don't have to acknowledge it. If it's too much to address this right now let's file a jira about it.

From fastest ways I can change it to pop up under a button, but then there would be no popover when user hover on an icon

Ok let's just file a jira for now

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit

LGTM, thank you!

Jakub-Sadowski added 7 commits December 16, 2020 09:19

contribution-guide
4cacad5

become a committer and twitter
f97933e

fix
89b99b1

update files
ca91cc2

Merge branch 'website-revamp' into website/contribute-twitter
e5c24b9

add license
054ee46

Merge branch 'website/contribute-twitter' ofhttps://github.com/Polid…
c5ef689
…eaInternal/beam into website/contribute-twitter

probot-autolabelerBot added the website label Dec 16, 2020

whitespaces
5c19e58

pabloem self-requested a review December 17, 2020 17:27

TheNeuralBit requested changes Dec 17, 2020
View reviewed changes

Comment threadwebsite/www/site/content/en/contribute/_index.md Outdated
Comment threadwebsite/www/site/content/en/contribute/become-a-committer.md

Jakub-Sadowski added 3 commits December 18, 2020 10:50

committer not commiter
3754bd1

uppercase
5665584

arrow-list template
62b882e

kgabryje reviewed Dec 28, 2020
View reviewed changes

Comment threadwebsite/www/site/assets/scss/_calendar.scss
Comment threadwebsite/www/site/assets/scss/lists.scss Outdated
Comment threadwebsite/www/site/content/en/contribute/_index.md Outdated

Jakub-Sadowski added 2 commits December 29, 2020 11:52

fix double right navigation
90b9f58

delete br's
a7d9b89

TheNeuralBit reviewed Jan 13, 2021
View reviewed changes

Jakub-Sadowski added 5 commits January 17, 2021 16:57

Merge branch 'website-revamp' into website/contribute-twitter
1b1bb2d

delete duplicated class
753d07c

changes
7f01d0a

fix typo
5134c39

update content
2dcca01

TheNeuralBit requested changes Feb 2, 2021
View reviewed changes

Comment threadwebsite/www/site/content/en/blog/adding-data-sources-to-sql.md Outdated

newer copy
34afada

TheNeuralBit reviewed Feb 2, 2021
View reviewed changes

Comment threadwebsite/www/site/data/en/ways_of_contribution.yaml Outdated
Comment threadwebsite/www/site/layouts/shortcodes/highlight.html Outdated

Jakub-Sadowski added 5 commits February 3, 2021 15:12

delete content
10fddfd

statics
b0cefb2

content
9164322

content updated
6e51078

merged conflicts
41ade20

TheNeuralBit reviewed Feb 3, 2021
View reviewed changes

Jakub-Sadowski added 4 commits February 3, 2021 21:26

first merge
38f4a96

second merge
506b783

fix typography:
95cbc01

fix of content
741504d

Jakub-Sadowski commented Feb 3, 2021
View reviewed changes

Comment threadwebsite/www/site/content/en/contribute/practises.md

fix
e820b7c

TheNeuralBit reviewed Feb 4, 2021
View reviewed changes

Jakub-Sadowski added 2 commits February 4, 2021 11:07

content fix
d638b20

highlight change
42b2b6a

TheNeuralBit reviewed Feb 4, 2021
View reviewed changes

Jakub-Sadowski added 3 commits February 4, 2021 17:33

fix contribution
08b6db4

fix navbar
4502c9a

content update
914843d

TheNeuralBit requested changes Feb 4, 2021
View reviewed changes

Jakub-Sadowskiand others added 3 commits February 4, 2021 20:32

fixes
50f5d5e

change div
98d2ca4

Update website/www/site/data/en/committer_traits.yaml
a26364f
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit reviewed Feb 5, 2021
View reviewed changes

Comment threadwebsite/www/site/layouts/shortcodes/highlight.html Outdated

Update website/www/site/layouts/shortcodes/highlight.html
7e84dd5
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit approved these changes Feb 5, 2021
View reviewed changes

TheNeuralBit merged commit a566b4e into apache:website-revampFeb 5, 2021

Uh oh!

Conversation

Jakub-Sadowski commented Dec 16, 2020

Post-Commit Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

Jakub-Sadowski commented Dec 16, 2020

Uh oh!

pabloem commented Dec 17, 2020

Uh oh!

TheNeuralBit commented Dec 17, 2020

Uh oh!

pabloem commented Dec 17, 2020

Uh oh!

TheNeuralBit commented Dec 17, 2020

Uh oh!

pabloem commented Dec 17, 2020 via email

Uh oh!

TheNeuralBit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jakub-Sadowski commented Dec 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jakub-Sadowski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBitFeb 4, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheNeuralBit left a comment •
edited
Loading

TheNeuralBitFeb 4, 2021•
edited
Loading