Skip to content

[BEAM-11665] Publish Beam GCP BOM - #13737

Merged
kennknowles merged 11 commits into
apache:masterfrom
kileys:beam-bom
Jan 25, 2021
Merged

[BEAM-11665] Publish Beam GCP BOM#13737
kennknowles merged 11 commits into
apache:masterfrom
kileys:beam-bom

Conversation

@kileys

@kileyskileys commented Jan 12, 2021

Copy link
Copy Markdown
Contributor
  • Create a Beam GCP BOM for projects that use Beam and Google Cloud Platform.
  • Create a Maven archetype using the new BOM and run examples on it
  • Add BOM validation to release jenkins test and validation script

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Gradle Publish

@codecov

codecovBot commented Jan 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #13737 (c5b7295) into master (6675586) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #13737 +/- ##
==========================================
- Coverage 82.75% 82.74% -0.01% 
==========================================
Files 466 466 Lines 57525 57525 ==========================================
- Hits 47604 47601 -3 - Misses 9921 9924 +3 
Impacted FilesCoverage Δ
.../python/apache_beam/testing/test_stream_service.py88.63% <0.00%> (-4.55%)⬇️
sdks/python/apache_beam/utils/interactive_utils.py88.09% <0.00%> (-2.39%)⬇️
...che_beam/runners/interactive/interactive_runner.py90.90% <0.00%> (-1.82%)⬇️
sdks/python/apache_beam/internal/metrics/metric.py86.45% <0.00%> (-1.05%)⬇️
sdks/python/apache_beam/transforms/util.py95.66% <0.00%> (-0.18%)⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py89.69% <0.00%> (-0.16%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.70% <0.00%> (-0.13%)⬇️
sdks/python/apache_beam/dataframe/frames.py91.88% <0.00%> (+0.41%)⬆️
sdks/python/apache_beam/runners/direct/executor.py96.82% <0.00%> (+0.52%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6675586...c5b7295. Read the comment docs.

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Gradle Publish

@suztomo

Copy link
Copy Markdown
Contributor

@kileys Can I see the generated BOM somewhere?

Comment threadsdks/java/bom/common.gradle Outdated
Comment threadsdks/java/bom/common.gradle Outdated
Comment threadsdks/java/bom/common.gradle Outdated
@kileys

kileys commented Jan 20, 2021

Copy link
Copy Markdown
ContributorAuthor

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Gradle Publish

@elharoelharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. <url>http://beam.apache.org</url> should use https
    2 <inceptionYear>2016</inceptionYear> should be 2021
  2. <organizationUrl>http://www.apache.org</organizationUrl> should use https
  3. <archive>http://www.mail-archive.com/dev%beam.apache.org</archive> should use https

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow PostRelease

2 similar comments
@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow PostRelease

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow PostRelease

@kileyskileys changed the title [WIP] Publish Beam GCP BOM[BEAM-11665] Publish Beam GCP BOMJan 20, 2021
@kileys

kileys commented Jan 20, 2021

Copy link
Copy Markdown
ContributorAuthor
  1. <url>http://beam.apache.org</url> should use https
    2 <inceptionYear>2016</inceptionYear> should be 2021
  2. <organizationUrl>http://www.apache.org</organizationUrl> should use https
  3. <archive>http://www.mail-archive.com/dev%beam.apache.org</archive> should use https

@elharo
That's an outdated pom before I made the changes. Also, for #2, it's inception year not current year.

Here's the newest pom:
https://repository.apache.org/content/repositories/snapshots/org/apache/beam/beam-sdks-java-google-cloud-platform-bom/2.28.0-SNAPSHOT/beam-sdks-java-google-cloud-platform-bom-2.28.0-20210120.122741-1.pom

@kileys

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow PostRelease

@kileys

Copy link
Copy Markdown
ContributorAuthor

R: @kennknowles

@suztomo

Copy link
Copy Markdown
Contributor

I see it's working as expected. (Effective pom after I replaced the version iwth the latest release 2.27: https://gist.github.com/suztomo/ab8bf9dc2653ce2a886a5a57a0204eb2#file-gistfile1-txt-L190 )

I want Guava version to be more higher: #13740

-PgcsBucket=${USER_GCS_BUCKET:5} # skip 'gs://' prefix

echo "**************************************************************************"
echo "* Java mobile game on DataflowRunner using Beam GCP BOM: UserScore, HourlyTeamScore, Leaderboard"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be included as part of the release validation spreadsheet?
In other words, is this required to pass to validate the RC?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kileys@suztomo@udim@kennknowles@elharo