Skip to content

[BEAM-11408] [cherry-pick] Integrate BigQuery sink streaming inserts with GroupIntoBatches - #13832

Merged
chamikaramj merged 1 commit into
apache:release-2.28.0from
nehsyc:cherry-pick-bq
Jan 29, 2021
Merged

[BEAM-11408] [cherry-pick] Integrate BigQuery sink streaming inserts with GroupIntoBatches#13832
chamikaramj merged 1 commit into
apache:release-2.28.0from
nehsyc:cherry-pick-bq

Conversation

@nehsyc

@nehsycnehsyc commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

Cherry-pick #13496 into 2.28.0 release.

R: @chamikaramj


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…sink streaming inserts with GroupIntoBatches
* Integrate BQ streaming inserts with GroupIntoBatches
* Moved autosharding option from BigQueryOption to BigQueryIOBuilder; addressed comments.
* fix checkstyle error
* Revert the logic that was dropped during merge
* Add comments for RequiresStableInput
@nehsyc

Copy link
Copy Markdown
ContributorAuthor

ReCommit failed due to this test MetricsTest$AttemptedMetricTests.testAllAttemptedMetrics with :runners:direct-java:needsRunnerTests. This PR includes some refactoring of metrics usage in BQ sink but the failed test doesn't look related. I ran it locally and it passed.

https://scans.gradle.com/s/jyulohgizhm7c/tests/:runners:direct-java:needsRunnerTests/org.apache.beam.sdk.metrics.MetricsTest$AttemptedMetricTests/testAllAttemptedMetrics?anchor=e30&expanded-stacktrace=WyIwIl0&focused-exception-line=0-2#1

@chamikaramj

Copy link
Copy Markdown
Contributor

Run Java PreCommit

@chamikaramj

Copy link
Copy Markdown
Contributor

LGTM. Thanks.

@chamikaramj
chamikaramj merged commit a7e598b into apache:release-2.28.0Jan 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nehsyc@chamikaramj