Uh oh!
There was an error while loading. Please reload this page.
[BEAM-11719 ] Use deterministic coders for grouping keys. - #13839
Conversation
ee5ef89 to
79301c4Compare79301c4 to
c93696aCompare…ion. Falling back to pickling for key grouping was never safe, and should not have been recommended.
c93696a to
98cc71fComparerobertwb
commented
Feb 19, 2021
R: @udim |
4b9fb15 to
64adb6aCompare42458d8 to
fd87993CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| deleting_tables: deleting_tables, | ||
| pvalue.AsIter(temp_tables_pc)) | ||
| | "RemoveTempTables/AddUselessValue" >> beam.Map(lambda x: (x, None)) | ||
| # TableReference has no deterministic coder, but as this de-duplication |
There was a problem hiding this comment.
From what I can tell, parse_table_reference is used to normalize and populate TableReference instances. They are essentially a "(project, dataset, table) tuple."
It should be possible to beam.Map(lambda x: (x.tableId, x.datasetId, x.projectId)) | beam.Distinct() | beam.Map(lambda x: parse_table_reference(*x))
cc: @pabloem
There was a problem hiding this comment.
Assuming exactly these three fields would not be as future proof.
There was a problem hiding this comment.
Ack. The official BigQuery client (which this code doesn't use) has a hashable wrapper for this.
https://googleapis.dev/python/bigquery/latest/generated/google.cloud.bigquery.table.TableReference.html
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| deleting_tables: deleting_tables, | ||
| pvalue.AsIter(temp_tables_pc)) | ||
| | "RemoveTempTables/AddUselessValue" >> beam.Map(lambda x: (x, None)) | ||
| # TableReference has no deterministic coder, but as this de-duplication |
There was a problem hiding this comment.
Assuming exactly these three fields would not be as future proof.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
robertwb
commented
Feb 24, 2021
Run Python_PVR_Flink PreCommit |
chunyang
commented
Feb 27, 2021
I seem to be bumping into an error caused by deterministic coder enforcement. Do you mind taking a look at ##14112? |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.