[BEAM-11618-11619-11605-11468-][Website revamp]Implemented capability matrix, powered by, beam practises, feedback component by Jakub-Sadowski · Pull Request #13858 · apache/beam

Jakub-Sadowski · 2021-01-31T16:10:30Z

Implemented:

capability matrix
powered by and use cases
beam practises page
feedback button

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	Dataflow	Samza	Twister2
Go	---	---	---
Java
Python		---	---
XLang		---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---		---	---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Jakub-Sadowski · 2021-01-31T16:16:21Z

Review: @TheNeuralBit

TheNeuralBit

I have some initial comments/questions. I still need to look over the templates but I'm out of time for today.

I tried to look at the new capability matrix in the website preview (http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html) but clicking Documentation > Runners doesn't work.

TheNeuralBit · 2021-02-02T02:11:07Z

+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->


Do we have any copy for Scio?

unfortunately no

@nevillelyh is there any chance you or someone else involved with Scio could provide a blurb about it for our new "powered by" card? For reference the blurb for Klio is:
Developed at Spotify and built on top of Apache Beam for Python, Klio is an open source framework that lets researchers and engineers build smarter data pipelines for processing audio and other media files, easily and at scale.

That is for Klio, a different, similarly named library from Spotify :)

Another issue I just noticed in the staged website, the footer is centered:
Merge of website-revamp fixed this

Let's file a jira to make sure we get some copy for Scio at some point

Jakub-Sadowski · 2021-02-02T11:13:18Z

I have some initial comments/questions. I still need to look over the templates but I'm out of time for today.
I tried to look at the new capability matrix in the website preview (http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html) but clicking Documentation > Runners doesn't work.

Are u sure? I just pulled this branch and capability is working fine (also incognito)

TheNeuralBit · 2021-02-02T15:55:18Z

Are u sure? I just pulled this branch and capability is working fine (also incognito)

Yes I'm sure. Note I didn't pull the branch and build the website locally, I'm going off the one that the "Website Stage GCS" job built, here: http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html

When I go to that page and click Documentation > Runners, it takes me to http://apache-beam-website-pull-requests.storage.googleapis.com/13858/documentation/runners/capability-matrix/index.html, which doesn't exist

TheNeuralBit · 2021-02-02T16:24:25Z

Another issue I just noticed in the staged website, the footer is centered:

Jakub-Sadowski · 2021-02-04T11:59:03Z

Are u sure? I just pulled this branch and capability is working fine (also incognito)
Yes I'm sure. Note I didn't pull the branch and build the website locally, I'm going off the one that the "Website Stage GCS" job built, here: http://apache-beam-website-pull-requests.storage.googleapis.com/13858/index.html
When I go to that page and click Documentation > Runners, it takes me to http://apache-beam-website-pull-requests.storage.googleapis.com/13858/documentation/runners/capability-matrix/index.html, which doesn't exist
You were right, git ignore blocked whole folder with capability matrix

TheNeuralBit

I have a couple of comments here, not finished looking it over though

TheNeuralBit

A few more comments here

TheNeuralBit · 2021-02-04T19:04:54Z

+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->


Let's file a jira to make sure we get some copy for Scio at some point

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

TheNeuralBit

I'm still seeing some scrolling issues with the capability matrix. Other than that and some other minor requests this is looking good.

TheNeuralBit · 2021-02-04T21:37:37Z

-PipelineResult which generally will be a job descriptor for your data
-processing engine, providing methods for checking its status, canceling it, and
-waiting for it to terminate.
-


We need to update the copy on this page and the new page based on this move (e.g. in the new page it says "From here on ...", but this is actually the end of the page). I'll file a jira to do that since I don't think we have time to do it now.

Co-authored-by: Brian Hulette <hulettbh@gmail.com>

Jakub-Sadowski added 3 commits January 31, 2021 17:01

init
2b85742

missing content
51d4b0d

Merge branch 'website-revamp' into website/capability-powered-practises
794b80f

Jakub-Sadowski added 7 commits January 31, 2021 17:39

search styles
e78a2b7

add link to feedback
d6d2f82

content update
8296b8d

examples update
adf5e58

fix powered by
30947bc

add page
904525d

Merge branch 'website-revamp' into website/capability-powered-practises
143fe40

TheNeuralBit self-requested a review February 2, 2021 01:25

TheNeuralBit reviewed Feb 2, 2021
View reviewed changes

Jakub-Sadowski added 2 commits February 2, 2021 12:18

fix
e44af6f

fix logos
1ba9e6d

Jakub-Sadowski changed the title ~~Website/capability powered practises~~[BEAM-11618-11619-11605-11468-][Website revamp]Implemented capability matrix, powered by, beam practises, feedback componentFeb 3, 2021

add capability
9b92f83

Jakub-Sadowski added 2 commits February 4, 2021 13:22

merged
943f9ec

change of sdks
19466cb

TheNeuralBit reviewed Feb 4, 2021
View reviewed changes

Comment threadwebsite/www/site/layouts/shortcodes/documentation/capability-matrix-single.html
Comment threadwebsite/www/site/layouts/partials/section-menu/en/contribute.html Outdated

TheNeuralBit reviewed Feb 4, 2021
View reviewed changes

Jakub-Sadowskiand others added 4 commits February 4, 2021 20:35

Update website/www/site/layouts/partials/feedback.html
60a797b
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

Update website/www/site/data/en/powered-by.yaml
7f44da1
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

fix content
da10bc5

fix matrix
630ec03

TheNeuralBit reviewed Feb 4, 2021
View reviewed changes

Jakub-Sadowskiand others added 8 commits February 5, 2021 09:48

Update website/www/site/data/en/powered-by.yaml
d021807
Co-authored-by: Brian Hulette <hulettbh@gmail.com>

basics
b2d075f

fix
8fd84e9

fix hero component:
aa4a277

fix mobile
6714e75

fix navigation
c194047

navbar fix
46860c0

merged
a16a426

TheNeuralBit approved these changes Feb 5, 2021
View reviewed changes

Comment threadwebsite/www/site/content/en/documentation/runners/basics.md

TheNeuralBit merged commit 02140ae into apache:website-revampFeb 5, 2021

Uh oh!

Conversation

Jakub-Sadowski commented Jan 31, 2021

Post-Commit Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

Jakub-Sadowski commented Jan 31, 2021

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheNeuralBitFeb 2, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jakub-Sadowski commented Feb 2, 2021

Uh oh!

TheNeuralBit commented Feb 2, 2021

Uh oh!

TheNeuralBit commented Feb 2, 2021

Uh oh!

Jakub-Sadowski commented Feb 4, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheNeuralBit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TheNeuralBitFeb 2, 2021•
edited
Loading

Jakub-Sadowski commented Feb 4, 2021•
edited
Loading