Skip to content

[BEAM-10961] Make mongo-java-driver dependency a named variable - #13910

Merged
ibzib merged 1 commit into
apache:masterfrom
sonam-vend:sdks-io-mongodb-driver-version
Feb 9, 2021
Merged

[BEAM-10961] Make mongo-java-driver dependency a named variable#13910
ibzib merged 1 commit into
apache:masterfrom
sonam-vend:sdks-io-mongodb-driver-version

Conversation

@shehzaadn-vd

Copy link
Copy Markdown
Contributor

This PR implements a change suggested in PR# 13830. The mongo_java_driver created here will subsequently be used in that PR.

R: @ibzib

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecovBot commented Feb 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #13910 (827c938) into master (52d0bd9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #13910 +/- ##
=======================================
Coverage 82.85% 82.85% =======================================
Files 466 466 Lines 57596 57596 =======================================
+ Hits 47719 47723 +4 + Misses 9877 9873 -4 
Impacted FilesCoverage Δ
sdks/python/apache_beam/io/localfilesystem.py91.66% <0.00%> (-0.76%)⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py89.54% <0.00%> (-0.16%)⬇️
setup.py0.00% <0.00%> (ø)
sdks/python/apache_beam/runners/common.py88.87% <0.00%> (+0.14%)⬆️
sdks/python/apache_beam/dataframe/frames.py90.94% <0.00%> (+0.41%)⬆️
sdks/python/apache_beam/internal/metrics/metric.py87.50% <0.00%> (+1.04%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d0bd9...827c938. Read the comment docs.

@shehzaadn-vd

Copy link
Copy Markdown
ContributorAuthor

@ibzib would you be able to review and merge this?

@ibzibibzib left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibzib
ibzib merged commit 705649d into apache:masterFeb 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shehzaadn-vd@ibzib