Uh oh!
There was an error while loading. Please reload this page.
[BEAM-11805] Revert version updates from #13765 - #13972
Conversation
This reverts commit e0ba4dc.
TheNeuralBit
commented
Feb 12, 2021
Run Java PostCommit |
Codecov Report
@@ Coverage Diff @@## master #13972 +/- ##
==========================================
+ Coverage 82.89% 82.94% +0.05%
==========================================
Files 466 469 +3 Lines 57728 58343 +615 ==========================================
+ Hits 47854 48394 +540 - Misses 9874 9949 +75
Continue to review full report at Codecov.
|
TheNeuralBit
commented
Feb 12, 2021
It looks like we may have a forward fix, see BEAM-11805. I'll look into it further and send a new PR tomorrow. |
kennknowles
commented
Feb 12, 2021
The dependency analysis is saying unusedDeclaredDeps for auto-value-annotations 1.7.2 and 1.7.4 across a few modules. Hrmm. |
TheNeuralBit
commented
Feb 12, 2021
Oh I just reverted the GCP BOM commit and not the AutoValue commit. I guess if we go forward with this we'll need to revert both. |
This reverts commit 5136c4e.
TheNeuralBit
commented
Feb 12, 2021
Run Java PostCommit |
TheNeuralBit
commented
Feb 12, 2021
I think we should send this PR to get CI green. Current breakage affects Java PostCommit as well as all Python PostCommits (The same spanner code is used in Python via xlang). CC: @allenpradeep if we roll this back you'll need to rollforward with your fix. |
kennknowles
commented
Feb 12, 2021
Agree. CI green is top priority. |
TheNeuralBit
commented
Feb 12, 2021
Run Java PreCommit |
TheNeuralBit
commented
Feb 13, 2021
PostCommit timed out, but SpannerReadIT did pass: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/573/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/ I'm going to go ahead and merge. |
This reverts #13765, as it breaks SpannerReadIT in Java PostCommit.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.