Skip to content

[BEAM-11805] Revert version updates from #13765 - #13972

Merged
TheNeuralBit merged 2 commits into
apache:masterfrom
TheNeuralBit:BEAM-11805
Feb 13, 2021
Merged

[BEAM-11805] Revert version updates from #13765#13972
TheNeuralBit merged 2 commits into
apache:masterfrom
TheNeuralBit:BEAM-11805

Conversation

@TheNeuralBit

@TheNeuralBitTheNeuralBit commented Feb 12, 2021

Copy link
Copy Markdown
Member

This reverts #13765, as it breaks SpannerReadIT in Java PostCommit.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

This reverts commit e0ba4dc.
@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

Run Java PostCommit

@codecov

codecovBot commented Feb 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #13972 (7929d6f) into master (dc29b8c) will increase coverage by 0.05%.
The diff coverage is 85.13%.

Impacted file tree graph

@@ Coverage Diff @@## master #13972 +/- ##
==========================================
+ Coverage 82.89% 82.94% +0.05% 
==========================================
Files 466 469 +3 Lines 57728 58343 +615 ==========================================
+ Hits 47854 48394 +540 - Misses 9874 9949 +75 
Impacted FilesCoverage Δ
..._beam/runners/portability/sdk_container_builder.py40.00% <7.69%> (-3.28%)⬇️
...nternal/clients/cloudbuild/cloudbuild_v1_client.py55.17% <55.17%> (ø)
...s/dataflow/internal/clients/cloudbuild/__init__.py80.00% <80.00%> (ø)
...ernal/clients/cloudbuild/cloudbuild_v1_messages.py100.00% <100.00%> (ø)
.../python/apache_beam/transforms/periodicsequence.py96.49% <0.00%> (-1.76%)⬇️
sdks/python/apache_beam/runners/direct/executor.py96.29% <0.00%> (-0.53%)⬇️
...thon/apache_beam/io/aws/clients/s3/boto3_client.py13.22% <0.00%> (-0.12%)⬇️
setup.py0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf4555...7929d6f. Read the comment docs.

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

It looks like we may have a forward fix, see BEAM-11805. I'll look into it further and send a new PR tomorrow.

@kennknowles

Copy link
Copy Markdown
Member

The dependency analysis is saying unusedDeclaredDeps for auto-value-annotations 1.7.2 and 1.7.4 across a few modules. Hrmm.

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

Oh I just reverted the GCP BOM commit and not the AutoValue commit. I guess if we go forward with this we'll need to revert both.

@TheNeuralBitTheNeuralBit changed the title [BEAM-11805] Revert GCP version updates from #13765[BEAM-11805] Revert version updates from #13765Feb 12, 2021
@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

Run Java PostCommit

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

I think we should send this PR to get CI green. Current breakage affects Java PostCommit as well as all Python PostCommits (The same spanner code is used in Python via xlang).

CC: @allenpradeep if we roll this back you'll need to rollforward with your fix.

@kennknowles

Copy link
Copy Markdown
Member

Agree. CI green is top priority.

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

Run Java PreCommit

@TheNeuralBit

Copy link
Copy Markdown
MemberAuthor

PostCommit timed out, but SpannerReadIT did pass: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/573/testReport/org.apache.beam.sdk.io.gcp.spanner/SpannerReadIT/

I'm going to go ahead and merge.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TheNeuralBit@kennknowles