Skip to content

[BEAM-11822] Revert "[BEAM-2914] Add portable merging window support to Python. (#12995)" - #14004

Merged
robertwb merged 1 commit into
apache:masterfrom
ajamato:rollback
Feb 17, 2021
Merged

[BEAM-11822] Revert "[BEAM-2914] Add portable merging window support to Python. (#12995)"#14004
robertwb merged 1 commit into
apache:masterfrom
ajamato:rollback

Conversation

@ajamato

Copy link
Copy Markdown

This reverts commit 625ee1f.

The commit broke ValidateRunnerXlangTest.combineGloballyTest broken in beam_PostCommit_XVR_Direct

See test failure details here:
https://issues.apache.org/jira/browse/BEAM-11822?filter=-2


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

LangSDKDataflowFlinkSamzaSparkTwister2
GoBuild Status---Build Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ajamato

Copy link
Copy Markdown
Author

R: @robertwb

@robertwbrobertwb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pure rollback? If so, LGTM.

@codecov

codecovBot commented Feb 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #14004 (9c60fd5) into master (8f87957) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@ Coverage Diff @@## master #14004 +/- ##
==========================================
- Coverage 82.94% 82.92% -0.03% 
==========================================
Files 469 469 Lines 58343 58233 -110 ==========================================
- Hits 48394 48287 -107 + Misses 9949 9946 -3 
Impacted FilesCoverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py93.95% <ø> (+0.09%)⬆️
...eam/runners/portability/fn_api_runner/execution.py92.03% <42.85%> (-1.65%)⬇️
...dks/python/apache_beam/runners/pipeline_context.py92.74% <0.00%> (-0.81%)⬇️
sdks/python/apache_beam/coders/coder_impl.py95.38% <0.00%> (-0.14%)⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py89.69% <0.00%> (+0.15%)⬆️
sdks/python/apache_beam/io/iobase.py84.81% <0.00%> (+0.26%)⬆️
sdks/python/apache_beam/io/localfilesystem.py92.42% <0.00%> (+0.75%)⬆️
sdks/python/apache_beam/internal/metrics/metric.py87.50% <0.00%> (+1.04%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f87957...9c60fd5. Read the comment docs.

@robertwb
robertwb merged commit 871e023 into apache:masterFeb 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ajamato@robertwb