Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10937] Tour of Beam: Reading and writing data notebook - #14045
Conversation
davidcavazos
commented
Feb 23, 2021
Will need to be added to the landing page #13747 as well, whichever merges first. |
aaltay
commented
Feb 24, 2021
I glanced at this. It looks good. Some high level comments:
I would like to load balance these reviews across the team. For this one I will nominate @emilymye in addition to @rosetn. Feel free to ping me once this is ready to merge after both reviews. |
davidcavazos
commented
Feb 26, 2021
Got it, I removed the info boxes about the disk speeds. I'm also renaming "Source" to "input transform" and "Sink" to "output transform" since that might be more accurate terms. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: emily <emilyye@google.com>
Co-authored-by: emily <emilyye@google.com>
Co-authored-by: emily <emilyye@google.com>
…avazos/beam into tour-of-beam-reading-writing-data
Co-authored-by: emily <emilyye@google.com>
…avazos/beam into tour-of-beam-reading-writing-data
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidcavazos
left a comment
There was a problem hiding this comment.
Thanks for the comments, here's the updated version.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidcavazos
commented
Mar 11, 2021
Hi @emilymye, can you take a look at this whenever you have a chance? Thank you! |
davidcavazos
commented
Mar 15, 2021
Hi @rosetn, I've addressed your review comments, please let me know what you think. |
davidcavazos
commented
Mar 16, 2021
Friendly ping @emilymye :) |
emilymye
commented
Mar 17, 2021
LGTM! @aaltay will have to actually approve and submit because I don't have committer access. |
aaltay
commented
Mar 17, 2021
Thank you! And thank you for the reviews! |
This is the second introductory notebook on how to read and write data.
It covers:
ReadFromTextandWriteToTexttransformsR: @aaltay
R: @rosetn
Staged:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.