[BEAM-11436] Never run checkerframework on tests

[TheNeuralBit]

Post-Commit Tests Status (on master branch)

Lang	SDK	Dataflow	Flink	Samza	Spark	Twister2
Go		---		---		---
Java
Python				---		---
XLang				---		---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---		---	---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[TheNeuralBit]

Note this doesn't remove the suppressions added in 5675108. I thought I might be able to back it out with git revert restricted to just test directories, but for some reason git flags trivial merge conflicts for seemingly any test file that's had a change made to it in the meantime, even though the changes are rarely on the same lines.

Maybe I can come up with a better approach in the morning.. (generate a patch and reverse it?)

[codecov]

Codecov Report

Merging #14101 (c159f45) into master (7a27c79) will increase coverage by 0.37%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #14101 +/- ##
==========================================
+ Coverage 83.04% 83.42% +0.37% 
==========================================
Files 469 469 Lines 58465 60259 +1794 ==========================================
+ Hits 48555 50271 +1716 - Misses 9910 9988 +78 

Impacted Files	Coverage Δ
...sdks/python/apache_beam/internal/metrics/metric.py	86.45% <0.00%> (-1.05%)	⬇️
...apache_beam/portability/api/beam_runner_api_pb2.py	100.00% <0.00%> (ø)
...sdks/python/apache_beam/transforms/environments.py	85.32% <0.00%> (+0.13%)	⬆️
...hon/apache_beam/runners/worker/bundle_processor.py	94.40% <0.00%> (+0.41%)	⬆️
...eam/runners/portability/fn_api_runner/execution.py	95.14% <0.00%> (+1.45%)	⬆️
...ks/python/apache_beam/runners/worker/data_plane.py	91.31% <0.00%> (+1.79%)	⬆️
...ild/srcs/sdks/python/apache_beam/runners/common.py	90.63% <0.00%> (+1.91%)	⬆️
...eam/runners/portability/fn_api_runner/fn_runner.py	92.10% <0.00%> (+2.23%)	⬆️
...on/apache_beam/runners/dataflow/dataflow_runner.py	84.94% <0.00%> (+2.65%)	⬆️
...rcs/sdks/python/apache_beam/transforms/timeutil.py	98.88% <0.00%> (+3.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6904d...c159f45. Read the comment docs.

[TheNeuralBit]

Ok, turns out the conflicts weren't trivial, because additional suppression were added in the meantime. I found the following worked:

# Remove any lines with just nullness TODO(BEAM-10402)
sed -Ei '/^\s*"nullness"\s*\/\/\s*TODO\(https:\/\/issues.apache.org\/jira\/browse\/BEAM-10402\)\s*$/d' **/test/**/*.java
# Run spotless, then remove empty SuppressWarnings annotations
./gradlew spotlessApply
sed -Ei '/@SuppressWarnings\(\{\}\)/d' **/test/**/*.java

Then I ran grep -IirnEl 'BEAM-10402' **/test/**/*.java to identify the last ~10 that needed to be cleaned up manually.

This is committed in ebe1105

[kennknowles]

LGTM. If you hit a problem removing the suppressions, might as well get the first commit in sooner, to speed up builds for anyone who experiences cache misses.

[TheNeuralBit]

Yeah I'll back out the suppression removal for now. It looks like it really did break Java PreCommit in a surprising way.

[TheNeuralBit]

blurgh. The surprising schemas breakage is caused by the first commit, probably the strange nullable annotation behavior again..

[TheNeuralBit]

if I'm being honest I don't quite understand why this works, but #14107 fixes this PR.

[TheNeuralBit]

Perhaps running checkerframework brings in the spotbugs annotations at compile time?

[TheNeuralBit]

Retest this please

[TheNeuralBit]

Run GoPortable PreCommit

[TheNeuralBit]

Run Java PreCommit

[TheNeuralBit]

Run Java_Examples_Dataflow PreCommit

[TheNeuralBit]

Run GoPortable PreCommit

[TheNeuralBit]

Oh. GoPortable PreCommit no longer exists.

[TheNeuralBit]

Run Java PreCommit

[TheNeuralBit]

Run Java_Examples_Dataflow PreCommit