Uh oh!
There was an error while loading. Please reload this page.
[BEAM-10961] Enable strict dependency checking for sdks/java/extensions/euphoria (second attempt) - #14126
Merged
Conversation
…/euphoria (second attempt)
4 tasks
ibzib
commented
Mar 2, 2021
Can you please remove the empty commit? |
shehzaadn-vdforce-pushed
the
sdks-extensions-euphoria-again
branch
from
March 3, 2021 01:25
6076f86 to
0fe4cceCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as PR #14083, which was merged successfully.
However, when PR #14084 was merged, one unintended effect was that the change from #14083 got reversed. This is potentially explained by the following: The change in #14083 had unintentionally moved into #14084 and one of the commits in #14084 was reversing that stray change. The merge commit for #14084 (b7125d0) in addition to the single file that was intended for #14084 also added this reversal commit.
R: @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.