Skip to content

[BEAM-12044] JdbcIO read: always force autocommit to false - #14349

Merged
aromanenko-dev merged 1 commit into
apache:masterfrom
turb:jbcio-autocommit-false
Mar 27, 2021
Merged

[BEAM-12044] JdbcIO read: always force autocommit to false#14349
aromanenko-dev merged 1 commit into
apache:masterfrom
turb:jbcio-autocommit-false

Conversation

@turb

@turbturb commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

According to PostgreSQL JDBC documentation, it is required to disable autocommit in order to allow cursor streaming.

In JdbcIO:1548 we have poolableConnectionFactory.setDefaultAutoCommit(false);, however it is only applicable to poolable datasource. So any other usage will eventually lead to OOM since the JDBC driver silently falls back to full memoization of the request result.

The commit disables autocommit more systematically.

Superseedes #14338

cc @jkff@aromanenko-dev

Post-Commit Tests Status (on master branch)

LangSDKULRDataflowFlinkSamzaSparkTwister2
Go------Build Status---Build Status---
JavaBuild StatusBuild StatusBuild Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
PythonBuild Status
Build Status
Build Status
---Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild Status---Build StatusBuild Status---Build Status---

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build Status------------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@aromanenko-devaromanenko-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @turb! LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@turb@aromanenko-dev