Skip to content

[BEAM-8706][BEAM-12287] Revert "[BEAM-8706] Bump antlr4 to 4.9.2" - #14787

Merged
pabloem merged 1 commit into
apache:masterfrom
boyuanzz:kafkaio
May 12, 2021
Merged

[BEAM-8706][BEAM-12287] Revert "[BEAM-8706] Bump antlr4 to 4.9.2"#14787
pabloem merged 1 commit into
apache:masterfrom
boyuanzz:kafkaio

Conversation

@boyuanzz

@boyuanzzboyuanzz commented May 11, 2021

Copy link
Copy Markdown
Contributor

This reverts commit f3fab5c

commit f3fab5c breaks KafkaIO performance test: https://ci-beam.apache.org/job/beam_PerformanceTests_Kafka_IO/2282/

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java KafkaIO Performance Test

@codecov

codecovBot commented May 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #14787 (5568951) into master (986d59e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #14787 +/- ##
=======================================
Coverage 83.78% 83.78% =======================================
Files 439 439 Lines 59117 59117 =======================================
Hits 49532 49532 Misses 9585 9585 
Impacted FilesCoverage Δ
...s/sdks/python/apache_beam/transforms/ptransform.py
...build/srcs/sdks/python/apache_beam/testing/util.py
...x/py38/build/srcs/sdks/python/apache_beam/error.py
...thon/apache_beam/runners/worker/sdk_worker_main.py
...d/srcs/sdks/python/apache_beam/metrics/__init__.py
...e_beam/io/gcp/big_query_query_to_table_pipeline.py
...ython/apache_beam/examples/complete/estimate_pi.py
.../python/apache_beam/io/gcp/resource_identifiers.py
...python/apache_beam/examples/streaming_wordcount.py
...pache_beam/runners/portability/artifact_service.py
... and 868 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986d59e...5568951. Read the comment docs.

@boyuanzzboyuanzz mentioned this pull request May 12, 2021
4 tasks
@boyuanzzboyuanzz changed the title [TEST ONLY] Revert "[BEAM-8706] Bump antlr4 to 4.9.2"[BEAM-8706] Revert "[BEAM-8706] Bump antlr4 to 4.9.2"May 12, 2021
@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

r: @masahitojp@pabloem

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java_Examples_Dataflow PreCommit

@boyuanzzboyuanzz changed the title [BEAM-8706] Revert "[BEAM-8706] Bump antlr4 to 4.9.2"[BEAM-8706][BEAM-12287] Revert "[BEAM-8706] Bump antlr4 to 4.9.2"May 12, 2021
@pabloem
pabloem merged commit 2c92b3f into apache:masterMay 12, 2021
@pabloem

Copy link
Copy Markdown
Member

LGTM thanks @boyuanzz

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@boyuanzz@pabloem