Skip to content

[BEAM-10670] Fix Kafka expansion issues introduced by PR14801 - #14849

Merged
boyuanzz merged 1 commit into
apache:masterfrom
boyuanzz:fix
May 21, 2021
Merged

[BEAM-10670] Fix Kafka expansion issues introduced by PR14801#14849
boyuanzz merged 1 commit into
apache:masterfrom
boyuanzz:fix

Conversation

@boyuanzz

@boyuanzzboyuanzz commented May 20, 2021

Copy link
Copy Markdown
Contributor

This is a followup change regarding to #14801 (comment)

cc: @ibzib@iemejia


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild Status---Build Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
---Build Status---
XLangBuild StatusBuild StatusBuild Status---Build Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@boyuanzz
boyuanzz requested a review from ihjiMay 20, 2021 18:43
@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Samza ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Spark ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Spark StructuredStreaming ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Twister2 ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Python Flink ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Python Spark ValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Flink PortableValidatesRunner Batch

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Flink PortableValidatesRunner Streaming

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Samza PortableValidatesRunner

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v2 PortableValidatesRunner Streaming

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v3 PortableValidatesRunner Streaming

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark PortableValidatesRunner Batch

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v2 PortableValidatesRunner Streaming

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Java Spark v2 PortableValidatesRunner Streaming Tests seems pretty flaky to me.

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v2 PortableValidatesRunner Streaming

1 similar comment
@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v2 PortableValidatesRunner Streaming

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Looking at the history, that's fairly flaky: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark2_Streaming/

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark v2 PortableValidatesRunner Streaming

@ihji

ihji commented May 20, 2021

Copy link
Copy Markdown
Contributor

LGTM.

@ibzib Have any idea why Spark v2 PortableValidatesRunner Streaming test is so flaky?

@ibzib

Copy link
Copy Markdown

LGTM.

@ibzib Have any idea why Spark v2 PortableValidatesRunner Streaming test is so flaky?

Spark portable streaming was left in the proof-of-concept state, and I haven't had time to keep the tests green. At this point it's probably more trouble than it's worth. I'm going to disable the test until we have the resources to actively maintain it.

@ihji

ihji commented May 21, 2021

Copy link
Copy Markdown
Contributor

Run Java Spark v2 PortableValidatesRunner Streaming

@ihji

ihji commented May 21, 2021

Copy link
Copy Markdown
Contributor

Keep failing. Interestingly every time it fails the number of failed tests are different.

@ibzib Would this be safe to be merged with the failed Run Java Spark v2 PortableValidatesRunner Streaming test? Or should we retry until it's green?

@ibzib

Copy link
Copy Markdown

Keep failing. Interestingly every time it fails the number of failed tests are different.

@ibzib Would this be safe to be merged with the failed Run Java Spark v2 PortableValidatesRunner Streaming test? Or should we retry until it's green?

This test suite is too unreliable to provide a useful signal. It's fine to ignore it.

@boyuanzz

Copy link
Copy Markdown
ContributorAuthor

I'll cherry-pick this into #14844 as well. Thanks for your help, Heejong and Kyle!

@boyuanzz
boyuanzz merged commit 2ad332b into apache:masterMay 21, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@boyuanzz@ihji@ibzib