Skip to content

[BEAM-12680] Calcite SqlTransform no longer experimental - #15244

Merged
apilloud merged 1 commit into
apache:masterfrom
apilloud:sqlga
Sep 3, 2021
Merged

[BEAM-12680] Calcite SqlTransform no longer experimental#15244
apilloud merged 1 commit into
apache:masterfrom
apilloud:sqlga

Conversation

@apilloud

Copy link
Copy Markdown
Member

Dropping experimental (and SuppressWarnings). Pending discussion on dev@.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild StatusBuild StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@ibzib

Copy link
Copy Markdown

I wonder if we should keep some of the UDF methods experimental. There are currently three registerUdf methods and we might introduce a fourth eventually for ScalarFn. And registerUdaf has always been a little sketchy since SQL UDAFs ignore many of the methods of CombineFn.

Otherwise LGTM.

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud
apilloudforce-pushed the sqlga branch 2 times, most recently from a6ca074 to feed23cCompareAugust 4, 2021 18:53
@apilloud

Copy link
Copy Markdown
MemberAuthor

Updated to mark UDF methods as experimental.

@ibzibibzib left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

I'm going to hold off on merging this until #14729 goes in. (We also need to figure out what is wrong with Java_Examples_Dataflow, but that isn't this PR.)

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow PreCommit

@apilloud

Copy link
Copy Markdown
MemberAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@apilloud
apilloud merged commit 1700099 into apache:masterSep 3, 2021
@apilloud
apilloud deleted the sqlga branch September 3, 2021 00:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@apilloud@ibzib