Uh oh!
There was an error while loading. Please reload this page.
[BEAM-11831] Partially Revert "[BEAM-11805] Replace user-agent for spanner (#13990)" - #15591
Conversation
TheNeuralBit
commented
Sep 24, 2021
Run Java PostCommit |
TheNeuralBit
commented
Sep 24, 2021
TheNeuralBit
commented
Sep 24, 2021
Run Java PreCommit |
TheNeuralBit
commented
Sep 27, 2021
R: @nielm |
allenpradeep
commented
Sep 28, 2021
Just wanted to confirm if the original issue that was saw earlier(as part of BEAM-11805) in the Cloud Spanner library is fixed.
|
thiagotnunes
commented
Sep 28, 2021
@allenpradeep6.4.0 should have the fixes we need |
TheNeuralBit
commented
Sep 28, 2021
Thanks for double-checking this. From jira:
So we should have the upstream fix now. To be sure, I also ran the Java PostCommit on this PR, which is what caught BEAM-11805. Note that SpannerReadIT is still passing. |
TheNeuralBit
commented
Sep 30, 2021
@allenpradeep does this look good given that we're on an appropriate version of the spanner client? |
TheNeuralBit
commented
Oct 5, 2021
R: @lukecwik |
allenpradeep
commented
Oct 5, 2021
LGTM |
TheNeuralBit
commented
Oct 5, 2021
Thank you! |
…nner (apache#13990)" (apache#15591) This partially reverts commit 4f78ab3.
This partially reverts the changes from #13990. All of the changes to
SpannerAccessorare reverted, except for the update to the comment that explains the purpose of the user-agent.ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.