Skip to content

[BEAM-12628] make AvroCoder#useReflectApi default to true - #15616

Merged
aromanenko-dev merged 1 commit into
apache:masterfrom
clairemcginty:update_avro_reflect_default
Sep 29, 2021
Merged

[BEAM-12628] make AvroCoder#useReflectApi default to true#15616
aromanenko-dev merged 1 commit into
apache:masterfrom
clairemcginty:update_avro_reflect_default

Conversation

@clairemcginty

@clairemcgintyclairemcginty commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

following up on discussion from https://issues.apache.org/jira/browse/BEAM-12628, this changes the default value of AvroCoder#useReflectApi to true. This means that by default, avro string fields will get decoded as CharSequences backed by java.lang.Strings not org.apache.avro.util.Utf8s. This matches Beam's behavior prior to version 2.30.

cc @RyanSkraba , @udim


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild StatusBuild StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@RyanSkrabaRyanSkraba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should restore the previous behaviour... Given the discussion on the #15292 this is what more developers that actually use this part of the code will expect!

@RyanSkraba

Copy link
Copy Markdown
Contributor

If there's going to be an 2.33.0-RC2, it would be really good to include this! It's fixing a really recent regression that touches pipelines in production, and it would be good to restore the expected behavior before new developers get used to the new behavior.

The original PR causing the regression: #14410

R: @aromanenko-dev I think you're up to date on the issue as well!

@aromanenko-dev
aromanenko-dev merged commit 2254f09 into apache:masterSep 29, 2021
@clairemcginty
clairemcginty deleted the update_avro_reflect_default branch September 29, 2021 16:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clairemcginty@RyanSkraba@aromanenko-dev