Uh oh!
There was an error while loading. Please reload this page.
[BEAM-12983] [Playground] Initial gRPC server - #15656
Merged
Merged
Conversation
ilya-kozyrev
commented
Oct 4, 2021
ContributorAuthor
ilya-kozyrevforce-pushed
the
BEAM-12983_initial_server
branch
from
October 8, 2021 14:41
da6dcdc to
e003742CompareContributor
There was a problem hiding this comment.
For a future PR we should address what is the minimum necessary.
Contributor
There was a problem hiding this comment.
Is this PR serving as a placeholder or do we need to include the environment library as part of this PR?
ContributorAuthor
There was a problem hiding this comment.
yes, I've synced all dependencies locally however include only server in this PR. That's just a placeholder
damondouglas
approved these changes
Oct 13, 2021
damondouglas
left a comment
Contributor
There was a problem hiding this comment.
@pabloem LGTM. Note this comment in the thread: #15656 (comment)
pabloem
commented
Oct 18, 2021
Member
can you address the merge conflicts? |
ilya-kozyrevforce-pushed
the
BEAM-12983_initial_server
branch
from
October 19, 2021 09:41
945e8e4 to
650b514Compareilya-kozyrev
commented
Oct 19, 2021
ContributorAuthor
@pabloem resolved conflicts, squashed commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial server implementation using grpcweb wrapper.
This PR requires changes from #15654, #15645,
All endpoints - just mock for testing and deployment purposes, future PRs will replace them.
Unit tests currently use grpc without the wrapper and will be changed when endpoints will be implemented.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.