Uh oh!
There was an error while loading. Please reload this page.
[BEAM-13430] Remove propdeps and replace with compileOnly - #16308
Conversation
cfa00ca to
721b671CompareUh oh!
There was an error while loading. Please reload this page.
b7d30c1 to
248929dCompareTheNeuralBit
commented
Dec 21, 2021
retest this please |
1 similar comment
TheNeuralBit
commented
Dec 21, 2021
retest this please |
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
8c8d247 to
9620cdeComparedpcollins-google
commented
Dec 21, 2021
retest this please |
1 similar comment
TheNeuralBit
commented
Dec 21, 2021
retest this please |
Still generate <scope>provided</scope> in the output POM
Still generate <scope>provided</scope> in the output POM
TheNeuralBit
commented
Dec 21, 2021
Change to SQL test for BEAM-13506 LGTM |
TheNeuralBit
left a comment
There was a problem hiding this comment.
LGTM
Noting here that @dpcollins-google locally verified that generated poms still include provided scope where necessary.
TheNeuralBit
commented
Dec 21, 2021
Python precommit failure looks like a flake |
lukecwik
commented
Dec 29, 2021
What was the reasoning behind going with Note there were a couple of |
aaltay
commented
Jan 5, 2022
@lukecwik - should this be a jira tracked as part of https://issues.apache.org/jira/browse/BEAM-13430 ? |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.