Skip to content

[BEAM-13557] [Playground] show code execution time - #16363

Merged
pabloem merged 5 commits into
apache:masterfrom
akvelon:BEAM-13557
Jan 12, 2022
Merged

[BEAM-13557] [Playground] show code execution time#16363
pabloem merged 5 commits into
apache:masterfrom
akvelon:BEAM-13557

Conversation

@ElessarST

Copy link
Copy Markdown
Contributor

Added code execution time to the UI.

Screen.Recording.2021-12-27.at.15.57.57.mov

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild StatusBuild StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.


void stopTimer() {
if (timer != null) {
timer?.cancel();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant question mark or null check.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question mark is required, because timer is not local variable

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question mark is just a shorthand null check, so this code compiles to:

if (timer != null) {
if (timer != null) {
timer.cancel();
}
}

notifyListeners();
return;
}
_executionTime = _createExecutionTimeStream();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add _executionTime?.close() above this line to prevent a memory leak. I'm concerned about the circular reference inside the stopTimer and tick methods. Normally circular references are fine in JavaScript, but in this case, the setTimeout loop might cause issues.

# Conflicts:
#	playground/frontend/lib/modules/editor/components/run_button.dart

void stopTimer() {
if (timer != null) {
timer?.cancel();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question mark is just a shorthand null check, so this code compiles to:

if (timer != null) {
if (timer != null) {
timer.cancel();
}
}

@pabloem

Copy link
Copy Markdown
Member

@ElessarST I'm happy to merge, or wait for addressing the question mark issue

@ElessarST

Copy link
Copy Markdown
ContributorAuthor

@ElessarST I'm happy to merge, or wait for addressing the question mark issue

Hi @pabloem , I removed the null check and left only question mark, could you please merge?

@pabloem

Copy link
Copy Markdown
Member

lgtm

@pabloem
pabloem merged commit e22444d into apache:masterJan 12, 2022
kennknowles added a commit to kennknowles/beam that referenced this pull request Jan 21, 2022
* github/master: (198 commits)
Merge pull request apache#16369 from [BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options
Merge pull request apache#16546 from [BEAM-13661] [BEAM-13704] [Playground] Update tags for examples/katas/unit-tests
Merge pull request apache#16540 from [BEAM-13678][Playground]Update Github Action To Deploy Examples
[BEAM-13430] Re-add provided configuration (apache#16552)
[BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks (apache#16575)
[BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours (apache#16576)
[BEAM-13699] Replace fnv with maphash. (apache#16573)
Update Java FnAPI beam master (apache#16572)
Merge pull request apache#16371 from [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website
Merge pull request apache#16373 from [BEAM-13515] [Playground] Hiding lines in an example that are not necessary
Merge pull request apache#16472: [BEAM-13697] Add SchemaFieldNumber annotation
[BEAM-13689] Output token elements when BQ batch writes complete.
Disable logging for memoization test. (apache#16556)
BEAM-13611 reactivating jdbcio xlang test
Revert "Merge pull request apache#15863 from [BEAM-13184] Autosharding for JdbcIO.write* transforms"
Remove obsolete commands from Inventory job. (apache#16564)
[BEAM-13688] fixed type in BPG 4.5.3 window section (apache#16560)
[BEAM-13683] Make cross-language SQL example pipeline (apache#16567)
Merge pull request apache#16243 from darshan-sj/feature/support-priority-spannerio - Making rpcPriority a ValueProvider in SpannerConfig
edited README and comments in Python multi-lang pipes examples
Merge pull request apache#16518 from [BEAM-13619] [Playground] Add loading animation to the catalog
Merge pull request apache#16519 from [BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example
Merge pull request apache#16533 from [BEAM-13548] [Playground] Add example description popover
Merge pull request apache#16531 from [BEAM-13567] [playground] Handle run code validation and preparation errors
Merge pull request apache#16370 from [BEAM-13556] playground - color and scroll tabs with new content
[BEAM-13611] Skip test_xlang_jdbc_write (apache#16554)
[BEAM-13015] Provide caching statistics in the status client. (apache#16495)
Merge pull request apache#16309: [BEAM-13503] Set a default value to throwWriteErrors in BulkIO constructor
[BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for user state and side inputs. (apache#16525)
[BEAM-13665] Make SpannerIO projectID optional again (apache#16547)
Merge pull request apache#16322 from [BEAM-13407] [Playground] Preload fonts for the web application
Merge pull request apache#16506 from [BEAM-13652][Playground] Send examples' links to the frontend
[BEAM-11808][BEAM-9879] Support aggregate functions with two arguments (apache#16200)
Update walkthrough.md (apache#16512)
[BEAM-13683] Correct SQL transform schema, fix expansion address override bug (apache#16551)
Merge pull request apache#16486 from [BEAM-13544][Playground] Add logs to examples CI/CD to see the progress
[BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2 (apache#16544)
[BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2 (apache#16543)
Also bump FnAPI container.
[BEAM-13680] Fixed code_repository (added pipelineUuid to RunCodeResult when status is "Finished")
[BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0 (apache#16509)
[BEAM-13430] Remove jcenter which will no longer contain any updates. (apache#16536)
Update GH Actions to use proper variables names and proper triggers
Remove jcenter repositories from gradle configuration. (apache#16532)
Merge pull request apache#16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api and index.store.stats_refresh_interval=0
[BEAM-13664] Fix Primitives hashing benchmark (apache#16523)
Bump beam container version.
[BEAM-12621] - Update Jenkins VMs to modern Ubuntu version (apache#16457)
doc tweaks (apache#16498)
Redirecting cross-language transforms content (apache#16504)
Remove tab from source.
Remove unnecessary fmt call in universal.go
Clean up string cast of bytes in vet.go and corresponding tests
fix capitalized error strings in expansionx
Remove unnecessary blank identifier assignment in harness.go
Replace string(buf.Bytes()) with buf.String() in coder_test.go
Replace bytes.Compare() with bytes.Equal() in test cases
Remove unnecessary fmt.Sprintf() in partition.go
Fix staticcheck errors in transforms directory
[BEAM-13590] Fix abc imports from collections (apache#15850)
Merge pull request apache#16482 from [BEAM-13429][Playground] Add builder for preparers
[BEAM-10206] Resolve go vet errors in protox package
[BEAM-12572] Run java examples on multiple runners (apache#16450)
[BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types and OTHER JDBC types in general
[BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema
[BEAM-12164]: Add SDF for reading change stream records
[BEAM-13455] Remove duplicated artifacts when using multiple environments with Dataflow Java
Merge pull request apache#16485 from [BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput
Merge pull request apache#16385 from [BEAM-13535] [Playground] add cancel execution button
[BEAM-12558] Fix doc typo.
Merge pull request apache#16467 from [BEAM-12164]: SpannerIO DetectNewPartitions SDF
Introduce the notion of a JoinIndex for fewer shuffles. (apache#16101)
[BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields (apache#14974)
Stronger typing inference for CoGBK. (apache#16465)
[BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only (apache#16496)
Provide API to check whether a hint is known.
[BEAM-8806] Integration test for SqsIO using Localstack
Split builder into several builder for each step of pipeline execution
[BEAM-13399] Move service liveness polling to Runner type (apache#16487)
Merge pull request apache#16325 from [BEAM-13471] [Playground] Tag existing unit-tests
Adds several example multi-language Python pipelines
[BEAM-13616][BEAM-13646] Update vendored calcite 1.28.0 with protobuf 3.19.2 (apache#16473)
Merge pull request apache#16374 from [BEAM-13398][Playground] Split LifeCycle to DTO and business logic
Merge pull request apache#16363 from [BEAM-13557] [Playground] show code execution time
Merge pull request apache#16149 from [BEAM-13113] [Playground] playground frontend documentation
Merge pull request apache#16469 from [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output
[BEAM-13641][Playground] Add SCIO SDK support on the CI/CD step
[BEAM-13638] Datatype of timestamp fields in SqsMessage for AWS IOs for SDK v2 was changed from String to long, visibility of all fields was fixed from package private to public
[BEAM-13616] Initial files for vendored gRPC 1.43.2 (apache#16460)
[BEAM-13432] Skip ExpansionService creation in Job Server (apache#16222)
[BEAM-13628] Update SideInputCache to use full Transform and SideInputIDs as token information (apache#16483)
[BEAM-13631] Add deterministic SQS message coder to fix reading from SQS in batch mode
[BEAM-8806] Integration test for SqsIO
[adhoc] Run spotlessApply on java examples to fix master
Merge pull request apache#16156 from [BEAM-13391] Fix temporary file format in WriteToBigQuery
Optional args and kwargs for named external transforms.
[BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation. (apache#16458)
[BEAM-3221] Improve documentation in model pipeline protos (apache#16474)
Merge pull request apache#16147 from [BEAM-13359] [Playground] Tag existing examples
[BEAM-13626] Remap expanded outputs after merging. (apache#16471)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ElessarST@pabloem@KonradJanica