Skip to content

[BEAM-13590] Renaming collections.Iterable to collections.abc.Iterable. - #16414

Closed
blais wants to merge 1 commit into
apache:masterfrom
blais:python310
Closed

[BEAM-13590] Renaming collections.Iterable to collections.abc.Iterable.#16414
blais wants to merge 1 commit into
apache:masterfrom
blais:python310

Conversation

@blais

@blaisblais commented Jan 2, 2022

Copy link
Copy Markdown
Contributor

In Python 3.10, the symbols under collections.abc.* are removed from collections.*.
They have been deprecated since 3.3.

(There may be other collections.abc to be replaced as well but this allows me to run some of the examples.)

In Python 3.10, this name is now removed.
Has been deprecated since 3.3.
@codecov

codecovBot commented Jan 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16414 (d10296c) into master (7487bf0) will increase coverage by 8.99%.
The diff coverage is 80.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #16414 +/- ##
==========================================
+ Coverage 74.64% 83.63% +8.99% 
==========================================
Files 647 450 -197 Lines 81385 61862 -19523 ==========================================
- Hits 60747 51740 -9007 + Misses 19667 10122 -9545 + Partials 971 0 -971 
Impacted FilesCoverage Δ
.../apache_beam/runners/direct/transform_evaluator.py90.31% <ø> (ø)
sdks/python/apache_beam/transforms/trigger.py89.86% <0.00%> (ø)
...ks/python/apache_beam/runners/worker/sideinputs.py87.96% <100.00%> (ø)
sdks/python/apache_beam/typehints/typecheck.py97.54% <100.00%> (ø)
sdks/python/apache_beam/typehints/typehints.py93.43% <100.00%> (ø)
sdks/python/apache_beam/io/source_test_utils.py88.47% <0.00%> (-1.39%)⬇️
sdks/go/pkg/beam/transforms/stats/max.go
sdks/go/pkg/beam/forward.go
sdks/go/pkg/beam/testing/passert/floats.go
sdks/go/pkg/beam/core/graph/bind.go
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7487bf0...d10296c. Read the comment docs.

@tvalentyn

tvalentyn commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

Thanks for your contribution! Looks like there were two other PRs on this: #15850 and #15415 that for some reason did not land.

#15850 looks most complete to me. I just resolved a conflict there and suggest we proceed with that PR and close this PR. Please comment on #15850 if you see any concerns as you looked at this most recently.

@tvalentyn

Copy link
Copy Markdown
Contributor

Closing in favor of #15850

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@blais@tvalentyn