Skip to content

Revert "Merge pull request #15863 from [BEAM-13184] Autosharding for … - #16569

Merged
pabloem merged 2 commits into
apache:masterfrom
pabloem:rollback-15863
Jan 20, 2022
Merged

Revert "Merge pull request #15863 from [BEAM-13184] Autosharding for …#16569
pabloem merged 2 commits into
apache:masterfrom
pabloem:rollback-15863

Conversation

@pabloem

Copy link
Copy Markdown
Member

…JdbcIO.write* transforms"

This reverts commit 818428f.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild StatusBuild StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…g for JdbcIO.write* transforms"
This reverts commit 818428f.
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It is an earlier duplicate of 2173354 run.

@chamikaramj

Copy link
Copy Markdown
Contributor

Can you also re-enable the failing test in the same PR by reverting #16554 ?

@pabloem

Copy link
Copy Markdown
MemberAuthor

r: @chamikaramj

also renabled the test

@chamikaramj

Copy link
Copy Markdown
Contributor

Run Python 3.8 PostCommit

@codecov

codecovBot commented Jan 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16569 (4f29108) into master (a5935c7) will increase coverage by 37.28%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #16569 +/- ##
===========================================
+ Coverage 46.32% 83.60% +37.28% 
===========================================
Files 201 452 +251 Lines 19734 62072 +42338 ===========================================
+ Hits 9141 51897 +42756 - Misses 9612 10175 +563 + Partials 981 0 -981 
Impacted FilesCoverage Δ
sdks/go/pkg/beam/beam.shims.go
sdks/go/pkg/beam/core/runtime/exec/fn_arity.go
sdks/go/pkg/beam/transforms/stats/sum_switch.go
sdks/go/pkg/beam/core/funcx/fn.go
sdks/go/pkg/beam/io/bigqueryio/bigquery.go
sdks/go/pkg/beam/core/runtime/coderx/int.go
sdks/go/pkg/beam/testing/passert/count.go
sdks/go/pkg/beam/transforms/stats/mean.go
sdks/go/pkg/beam/io/filesystem/util.go
sdks/go/pkg/beam/core/runtime/graphx/dataflow.go
... and 643 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5935c7...4f29108. Read the comment docs.

@chamikaramj

Copy link
Copy Markdown
Contributor

LGTM. Thanks.

@chamikaramj

Copy link
Copy Markdown
Contributor

(post-commit is still pending)

@pabloem
pabloem merged commit a00634d into apache:masterJan 20, 2022
@pabloem
pabloem deleted the rollback-15863 branch January 21, 2022 19:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pabloem@chamikaramj