Revert "Revert "Merge pull request #15863 from [BEAM-13184] Autoshard…

[pabloem]

…ing for JdbcIO.write* transforms""

This change had been reverted because a previous change ignored a batchSize parameter, which caused a few tests to fail. We rolled back, fixed, and rolled forward the change.

This reverts commit 421bc80.

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Choose reviewer(s) and mention them in a comment (R: @username).
• Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---					---
Java
Python	---					---
XLang						---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

[pabloem]

Run Python 3.8 PostCommit

[pabloem]

Run Python 3.8 PostCommit

[pabloem]

Run Java PreCommit

[pabloem]

https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/393/testReport/apache_beam.io.external.xlang_jdbcio_it_test/ jdbcio xlang test works : )

@chamikaramj PTAL

[pabloem]

Run Java PostCommit

[pabloem]

@chamikaramj PTAL

[aromanenko-dev]

Sorry if I missed that but what is a reason to revert it?

[pabloem]

hey @aromanenko-dev - this change had broken xlang_jdbcio_it_test. Since the release cut was coming up, and I did not mind waiting until the next release, I decided to revert it and remake the change while ensuring xlang_jdbcio_it_test would pass

[aromanenko-dev]

Run Java PostCommit

[aromanenko-dev]

Hey @pabloem, thanks for details. LGTM

this change had broken xlang_jdbcio_it_test

Do you know what is a cause of this? Can it be fixed?

[chamikaramj]

Thanks. LGTM.

Could you clarify the diff between this and the original PR in the PR description ?

@aromanenko-dev I think this includes the fix.

[pabloem]

what happened is that the previous change ignored the batchSize parameter, and one of the python tests was verifying the batch size, which is interesting. This change now continues to respect the batchSize parameter

[pabloem]

thanks both!