Uh oh!
There was an error while loading. Please reload this page.
[BEAM-121] DisplayData API tweaks - #166
Conversation
swegner
commented
Apr 11, 2016
R: @bjchambers |
bjchambers
commented
Apr 11, 2016
I see test failures. Can you verify that nothing is broken? |
| } | ||
| addList(getProperties(), name, serializedItems); | ||
| List list = MAPPER.convertValue(displayData, List.class); |
6701f4b to
a15ed66Compareswegner
commented
Apr 12, 2016
Ok, this should build clean now. @bjchambers, can you take another look? Once this is in I'll rebase other PR's on top and we can have another round of feedback on those. |
| JsonNode json = MAPPER.readTree(MAPPER.writeValueAsBytes(data)); | ||
| assertThat(json, hasItem(expectedJson(component.getClass(), "STRING", "string", "\"foobar\""))); | ||
| assertThat(json, hasItem(expectedJson(component.getClass(), "INTEGER", "long", "1234"))); |
There was a problem hiding this comment.
This test may be easier to read (and verify it matches expectations) if it just has the expected value as a single string, or a string for each value.
swegner
commented
Apr 13, 2016
I've addressed all feedback so far. Please take another look. @bjchambers |
bjchambers
commented
Apr 13, 2016
LGTM |
davorbonaci
commented
Apr 15, 2016
@swegner, did we backport this? (Cc: @bjchambers) |
swegner
commented
Apr 15, 2016
I haven't done any backporting work for recent PRs-- I'm not quite familiar with the process. I'll work with @bjchambers on this. |
swegner
commented
May 16, 2016
Backported via GoogleCloudPlatform/DataflowJavaSDK#216 |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.