Uh oh!
There was an error while loading. Please reload this page.
Make num-stages counter into an internal counter. - #16638
Conversation
This unbreaks tests that (arguably to brittly) reject extra counters.
robertwb
commented
Jan 27, 2022
robertwb
commented
Jan 28, 2022
Run Python PreCommit |
| str(type(self)), | ||
| self.NUM_FUSED_STAGES_COUNTER, | ||
| urn='internal:' + self.NUM_FUSED_STAGES_COUNTER)).update( | ||
| len(stages)) |
There was a problem hiding this comment.
I guess internal: is a concept already defined somewhere?
There was a problem hiding this comment.
Yeah, there's some inconsistencies here with "user" counters requiring a name and namespace and "non-user" counters using the first component of the urn as a namespace and the rest as the name.
robertwb
commented
Jan 28, 2022
The failing tests apache_beam.transforms.create_test.CreateTest.test_create_uses_coder_for_pickling look unrelated. Trying again. |
robertwb
commented
Jan 28, 2022
Run Python PreCommit |
robertwb
commented
Jan 28, 2022
TheNeuralBit
commented
Jan 31, 2022
Run Python PreCommit |
ibzib
commented
Feb 2, 2022
I tried deflaking the Actions tests but it's unlikely to work since the rate of flakes is so high, there's no way to re-run individual actions, and the flakes can affect 8 different actions... I'm just going to merge this |
TheNeuralBit
commented
Feb 2, 2022
TheNeuralBit
commented
Feb 2, 2022
I suppose the merge ref is likely just created once when the PR is created and not updated. |

This unbreaks tests that (arguably to brittly) reject extra counters.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.