Uh oh!
There was an error while loading. Please reload this page.
[BEAM-13430] Fix provided configuration by removing extendsFrom for implementation - #16688
Merged
Conversation
dpcollins-google
approved these changes
Feb 1, 2022
lukecwik
requested changes
Feb 1, 2022
Uh oh!
There was an error while loading. Please reload this page.
emilymye
commented
Feb 1, 2022
ContributorAuthor
Run Java_Examples_Dataflow PreCommit |
emilymye
commented
Feb 1, 2022
ContributorAuthor
Run Java_PVR_Flink_Docker PreCommit |
lukecwik
reviewed
Feb 1, 2022
Uh oh!
There was an error while loading. Please reload this page.
emilymyeforce-pushed
the
fiximplementation
branch
from
February 1, 2022 22:20
689a829 to
a26f06dCompareemilymye
commented
Feb 1, 2022
ContributorAuthor
Run Java PreCommit |
emilymye
commented
Feb 1, 2022
ContributorAuthor
Run Java_Examples_Dataflow_Java11 PreCommit |
emilymye
commented
Feb 1, 2022
ContributorAuthor
Run Java_PVR_Flink_Docker PreCommit |
emilymyeforce-pushed
the
fiximplementation
branch
from
February 2, 2022 06:36
a26f06d to
70d992aCompareemilymye
commented
Feb 2, 2022
ContributorAuthor
Run Java PostCommit |
4 tasks
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run Java Flink PortableValidatesRunner Batch |
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run Spark ValidatesRunner |
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run Java Spark PortableValidatesRunner Batch |
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run SQL PostCommit |
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run Java PreCommit |
kennknowles
approved these changes
Feb 2, 2022
kennknowles
left a comment
Member
There was a problem hiding this comment.
This makes sense. I always found that line suspicious, but I don't know enough about how we are (ab)using Gradle.
emilymye
commented
Feb 2, 2022
ContributorAuthor
Run Java PreCommit |
emilymye added a commit
to emilymye/beam
that referenced
this pull request
Feb 2, 2022
4 tasks
emilymye added a commit
to emilymye/beam
that referenced
this pull request
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1597-L1598 is pulling in provided dependencies and generating them as "compile" dependencies
Based on https://cwiki.apache.org/confluence/display/BEAM/Gradle+Tips, this will add provided to the same classpaths
R: @lukecwik@kennknowles@dpcollins-google
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.