Skip to content

[BEAM-13430] Fix provided configuration by removing extendsFrom for implementation - #16688

Merged
emilymye merged 4 commits into
apache:masterfrom
emilymye:fiximplementation
Feb 2, 2022
Merged

[BEAM-13430] Fix provided configuration by removing extendsFrom for implementation#16688
emilymye merged 4 commits into
apache:masterfrom
emilymye:fiximplementation

Conversation

@emilymye

@emilymyeemilymye commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L1597-L1598 is pulling in provided dependencies and generating them as "compile" dependencies

Based on https://cwiki.apache.org/confluence/display/BEAM/Gradle+Tips, this will add provided to the same classpaths

R: @lukecwik@kennknowles@dpcollins-google

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

LangULRDataflowFlinkSamzaSparkTwister2
Go---Build StatusBuild StatusBuild StatusBuild Status---
JavaBuild StatusBuild Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python---Build Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild Status---
XLangBuild StatusBuild Status
Build Status
Build Status
Build StatusBuild StatusBuild Status---

Examples testing status on various runners

LangULRDataflowFlinkSamzaSparkTwister2
Go---------------------
Java---Build Status
Build Status
Build Status
---------------
Python---------------------
XLang---------------------

Post-Commit SDK/Transform Integration Tests Status (on master branch)

GoJavaPython
Build StatusBuild StatusBuild Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

---JavaPythonGoWebsiteWhitespaceTypescript
Non-portableBuild Status
Build Status
Build Status
Build Status
Build Status
Build StatusBuild StatusBuild StatusBuild Status
Portable---Build StatusBuild Status---------

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

Comment threadbuildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy Outdated
@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java_Examples_Dataflow PreCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java_PVR_Flink_Docker PreCommit

@codecov

codecovBot commented Feb 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #16688 (4d6a477) into master (b9c4919) will increase coverage by 8.99%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #16688 +/- ##
==========================================
+ Coverage 74.63% 83.63% +8.99% 
==========================================
Files 654 452 -202 Lines 81956 62146 -19810 ==========================================
- Hits 61170 51975 -9195 + Misses 19799 10171 -9628 + Partials 987 0 -987 
Impacted FilesCoverage Δ
sdks/python/apache_beam/utils/interactive_utils.py92.68% <0.00%> (-2.44%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.26% <0.00%> (-0.25%)⬇️
sdks/go/pkg/beam/util.go
sdks/go/pkg/beam/core/runtime/pipelinex/util.go
sdks/go/pkg/beam/core/runtime/exec/coder.go
sdks/go/pkg/beam/core/runtime/exec/reshuffle.go
sdks/go/pkg/beam/core/runtime/exec/fn_arity.go
sdks/go/pkg/beam/core/runtime/exec/datasink.go
sdks/go/pkg/beam/core/runtime/graphx/user.go
sdks/go/pkg/beam/core/runtime/exec/pcollection.go
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c4919...4d6a477. Read the comment docs.

Comment threadrunners/flink/flink_runner.gradle Outdated
@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java_Examples_Dataflow_Java11 PreCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java_PVR_Flink_Docker PreCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java Flink PortableValidatesRunner Batch

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Spark ValidatesRunner

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java Spark PortableValidatesRunner Batch

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run SQL PostCommit

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@kennknowleskennknowles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. I always found that line suspicious, but I don't know enough about how we are (ab)using Gradle.

@emilymye

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@emilymye
emilymye merged commit 6e2409f into apache:masterFeb 2, 2022
@emilymye
emilymye deleted the fiximplementation branch February 2, 2022 19:36
emilymye added a commit to emilymye/beam that referenced this pull request Feb 2, 2022
emilymye added a commit to emilymye/beam that referenced this pull request Feb 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@emilymye@kennknowles@lukecwik@dpcollins-google