Skip to content

[BEAM-12164]: display the metadata table name for Spanner Change Streams Connector - #16845

Merged
pabloem merged 1 commit into
apache:masterfrom
hengfengli:allow-custom-metadata-table
Mar 10, 2022
Merged

[BEAM-12164]: display the metadata table name for Spanner Change Streams Connector#16845
pabloem merged 1 commit into
apache:masterfrom
hengfengli:allow-custom-metadata-table

Conversation

@hengfengli

@hengfenglihengfengli commented Feb 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This adds the name of the metadata table to display in the Pipeline Options of the Dataflow UI.

@hengfengli

hengfengli commented Feb 14, 2022

Copy link
Copy Markdown
ContributorAuthor

CC @thiagotnunes

zoercai
zoercai approved these changes Feb 14, 2022
View reviewed changes
Comment thread...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java Outdated
@hengfengli
hengfengliforce-pushed the allow-custom-metadata-table branch 5 times, most recently from b18372b to 9ae1b87CompareFebruary 15, 2022 06:05
@hengfengli

hengfengli commented Feb 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@pabloem Can you please take a quick review on this PR? Thanks!

@hengfengli

hengfengli commented Feb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Please do not merge at the moment. I am investigating if we can pass the state via pipeline options between two jobs during the hot deploy.

@aaltay

aaltay commented Feb 25, 2022

Copy link
Copy Markdown
Member

@hengfengli - What is the next step on this PR?

@hengfengli

hengfengli commented Feb 28, 2022

Copy link
Copy Markdown
ContributorAuthor

@aaltay Sorry for the delay. I have tested that the pipeline option would not pass between jobs during a hot deploy (set the pipeline option in the old job and see it in the updated job). So this PR can be merged now.

@hengfengli
hengfengliforce-pushed the allow-custom-metadata-table branch from 401bba5 to 4990612CompareFebruary 28, 2022 06:11
@hengfenglihengfengli changed the title [BEAM-12164]: allow to specify a custom metadata table for Spanner Change Streams Connector[BEAM-12164]: display the metadata table name for Spanner Change Streams ConnectorFeb 28, 2022
@hengfengli

hengfengli commented Feb 28, 2022

Copy link
Copy Markdown
ContributorAuthor

As the change to allow to specify a custom metadata table is implemented in #16846, this PR is only for displaying the name of the metadata table on the Dataflow UI.

@hengfengli
hengfengliforce-pushed the allow-custom-metadata-table branch from 4990612 to 7dba96bCompareFebruary 28, 2022 06:21
@hengfengli

hengfengli commented Feb 28, 2022

Copy link
Copy Markdown
ContributorAuthor

The failed test is unrelated to this change.

@hengfengli
hengfengliforce-pushed the allow-custom-metadata-table branch from 7dba96b to cb4efc7CompareMarch 6, 2022 22:53
@hengfengli

hengfengli commented Mar 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@pabloem Can you please take a look and help us to merge this PR? Thanks.

@aaltay
aaltay requested a review from pabloemMarch 7, 2022 16:26
@pabloem

pabloem commented Mar 10, 2022

Copy link
Copy Markdown
Member

LGTM

@pabloem
pabloem merged commit e1a84ff into apache:masterMar 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pabloempabloemAwaiting requested review from pabloem
2 more reviewers
@thiagotnunesthiagotnunesthiagotnunes approved these changes
@zoercaizoercaizoercai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

gcpiojava

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hengfengli@aaltay@pabloem@thiagotnunes@zoercai