Uh oh!
There was an error while loading. Please reload this page.
[BEAM-14116] Chunk commit requests dynamically - #17004
Conversation
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This ensures they do not materialize all data at once for large requests
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This ensures they do not materialize all data at once for large requests
This ensures they do not materialize all data at once for large requests
dpcollins-google
commented
Mar 4, 2022
Run Java PreCommit |
scwhittle
left a comment
There was a problem hiding this comment.
LGTM, though you'll have to find someone else to merge
Uh oh!
There was an error while loading. Please reload this page.
scwhittle
commented
Mar 14, 2022
Run Java PreCommit |
TheNeuralBit
commented
Mar 16, 2022
Is there a jira for this that we can tag? |
lukecwik
commented
Mar 24, 2022
This change breaks the cloud/dataflow/testing/integration/sdk:streaming_GroupByKeyTest_BasicTests_testLargeKeys1MB_wm_service_local test reliably for Dataflow. @youngoli Resolution of whether this should be rolled back or forward fixed looks like will impact the 2.38 release. |
youngoli
commented
Mar 24, 2022
I'm open to cherry-picking in a forward fix since this was caught so soon after the cut. I just need an estimate of how long a fix would take to implement (I can wait a bit for this to get triaged so we can get an estimate). If a fix would take more than three days or so then probably better to just roll back. |
This reverts commit 8ae7628.
…lback of #17004: Chunk commit requests dynamically [rollback][release-2.38.0][BEAM-14116] Rollback of #17004: Chunk commit requests dynamically
This reverts commit 8ae7628.
This ensures they do not materialize all data at once for large requests
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.