Skip to content

[BEAM-14071] Enabling Flink on Dataproc for Interactive Beam - #17044

Merged
nika-qubit merged 1 commit into
apache:masterfrom
victorplusc:enable_flink_on_dataproc
Mar 21, 2022
Merged

[BEAM-14071] Enabling Flink on Dataproc for Interactive Beam#17044
nika-qubit merged 1 commit into
apache:masterfrom
victorplusc:enable_flink_on_dataproc

Conversation

@victorplusc

@victorpluscvictorplusc commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov

codecovBot commented Mar 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17044 (b6ccca7) into master (bdc3162) will increase coverage by 0.16%.
The diff coverage is 35.92%.

❗ Current head b6ccca7 differs from pull request most recent head 9ccaa12. Consider uploading reports for the commit 9ccaa12 to get more accurate results

@@ Coverage Diff @@## master #17044 +/- ##
==========================================
+ Coverage 73.79% 73.96% +0.16% 
==========================================
Files 663 671 +8 Lines 87056 88232 +1176 ==========================================
+ Hits 64243 65259 +1016 - Misses 21729 21861 +132 - Partials 1084 1112 +28 
FlagCoverage Δ
python83.64% <ø> (+0.02%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/go/pkg/beam/core/graph/window/windows.go82.60% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/util.go74.28% <ø> (ø)
sdks/go/pkg/beam/core/runtime/harness/harness.go11.26% <0.00%> (-1.43%)⬇️
sdks/go/pkg/beam/core/util/reflectx/tags.go0.00% <ø> (ø)
sdks/go/pkg/beam/forward.go40.00% <ø> (ø)
sdks/go/pkg/beam/runners/direct/buffer.go77.46% <ø> (ø)
sdks/go/pkg/beam/util/gcsx/gcs.go27.41% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/plan.go48.61% <22.22%> (-8.80%)⬇️
sdks/go/pkg/beam/core/runtime/exec/pardo.go50.45% <25.00%> (ø)
...kg/beam/core/runtime/xlangx/expansionx/download.go61.53% <61.53%> (+1.16%)⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc3162...9ccaa12. Read the comment docs.

@victorplusc

Copy link
Copy Markdown
ContributorAuthor

R: @kevingg
R: @rohdesamuel

@nika-qubitnika-qubit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits.

Comment threadsdks/python/apache_beam/runners/interactive/cache_manager.py Outdated
@victorplusc
victorpluscforce-pushed the enable_flink_on_dataproc branch 3 times, most recently from f8251f2 to 10d999fCompareMarch 16, 2022 20:20
@victorplusc
victorpluscforce-pushed the enable_flink_on_dataproc branch 3 times, most recently from f2c3d62 to 477c980CompareMarch 17, 2022 17:27

@nika-qubitnika-qubit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

@victorplusc
victorpluscforce-pushed the enable_flink_on_dataproc branch from b6ccca7 to 9ccaa12CompareMarch 21, 2022 17:56
@nika-qubit
nika-qubit merged commit d352d60 into apache:masterMar 21, 2022
@victorplusc
victorplusc deleted the enable_flink_on_dataproc branch March 21, 2022 20:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@victorplusc@nika-qubit@rohdesamuel