Skip to content

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch - #17259

Closed
youngoli wants to merge 1 commit into
apache:release-2.38.0from
youngoli:postcommit_validation_pr
Closed

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch#17259
youngoli wants to merge 1 commit into
apache:release-2.38.0from
youngoli:postcommit_validation_pr

Conversation

@youngoli

Copy link
Copy Markdown
Contributor

You can run many tests automatically using release/src/main/scripts/mass_comment.py.

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run CommunityMetrics PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Runner Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Runner V2 Java 11 Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Runner V2 Java 17 Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Runner V2 Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Streaming ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow ValidatesRunner Java 11

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow ValidatesRunner Java 17

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Direct Runner Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Direct ValidatesRunner Java 11

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Direct ValidatesRunner Java 17

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Direct ValidatesRunner in Java 11

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Direct ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Flink Runner Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner Java 11

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Go Flink ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Go PostCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Go PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Go Samza ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Go Spark ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run GoPortable PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java 11 Examples on Dataflow Runner V2

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java 17 Examples on Dataflow Runner V2

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java Dataflow V2 ValidatesRunner Streaming

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java Dataflow V2 ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java Examples on Dataflow Runner V2

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java Examples_Direct

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python 3.8 PostCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python 3.9 PostCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Dataflow V2 ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Dataflow ValidatesContainer

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Dataflow ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Examples_Dataflow

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Examples_Direct

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Examples_Flink

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Examples_Spark

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Flink ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Samza ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python Spark ValidatesRunner

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PythonDocker PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PythonDocs PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PythonFormatter PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PythonLint PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Python_PVR_Flink PreCommit

@codecov

codecovBot commented Apr 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17259 (92ca0bd) into release-2.38.0 (47a9d8f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## release-2.38.0 #17259 +/- ##
==================================================
- Coverage 73.96% 73.96% -0.01% 
==================================================
Files 672 672 Lines 88259 88270 +11 ==================================================
+ Hits 65279 65287 +8 - Misses 21867 21870 +3 
Partials 1113 1113 
FlagCoverage Δ
python83.63% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
...che_beam/runners/interactive/interactive_runner.py92.85% <0.00%> (-0.72%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.26% <0.00%> (-0.25%)⬇️
.../apache_beam/options/pipeline_options_validator.py98.90% <0.00%> (+0.03%)⬆️
...dks/python/apache_beam/options/pipeline_options.py94.91% <0.00%> (+0.05%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a9d8f...92ca0bd. Read the comment docs.

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Flink ValidatesRunner Java 11

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow Runner V2 Nexmark Tests

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Dataflow ValidatesRunner Java 17

@youngoli

youngoli commented Apr 5, 2022

Copy link
Copy Markdown
ContributorAuthor

Logging my triaging on all the failing targets for transparency.

Non-release blocking failures:
CommunityMetrics - Problem in our test infrastructure preventing metrics from being uploaded. Unrelated to Beam itself.
Google Cloud Dataflow Portability Runner Examples Java 11 - False negative. The build is successful but no tests are run and Jenkins reports that as a failure.
[Google Cloud Dataflow Runner V2 Examples](Google Cloud Dataflow Runner V2 Examples) - False negative, same as above.
Java Flink PortableValidatesRunner Streaming Tests - Only error has apparently been failing since being added, which is not a significant regression and therefore not release-blocking. BEAM-14254
Java Samza PortableValidatesRunner Tests - Only failure is the same as the Flink one above, and it's because Samza doesn't support the feature being tested.
Java Spark v2 PortableValidatesRunner Streaming Tests - Not considered release-blocking since the test suite was never consistently green to begin with. See BEAM-13950.
Python 3.7 PostCommit - Almost certainly a test configuration error and probably a flake. Failing to connect to a bigquery table. I'll be trying to deflake this just in case.
PythonDocs PreCommit - Fixed by #17176, I missed that during cherrypicks. Easy fix.

Further investigation needed:
Dataflow Java Post Commit Tests - Many failures. Most seem likely to be non-release blocking, but still looking into it. BEAM-14252
Dataflow V2 Java Post Commit Tests - Fewer failures than above, but some are identical failures and covered by the JIRA above. Then there's two spanner test failures that seem to be due to an incorrect config. Only new failure is not release-blocking (BEAM-14263).
JPMS Java 11 Dataflow Post Commit Tests and JPMS Java 17 Dataflow Post Commit Tests - Failing due to lack of Dataflow worker container for 2.38.0. Will need to rerun once it's available.
Java PreCommit - Been constantly timing out recently and being very flaky. Will need to keep rerunning until it doesn't timeout to see if it's actually failing or not.
Java SDK Post Commit Tests - Same failures as the Dataflow Java Post Commit Tests, so investigating BEAM-14252 will cover this.

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PostCommit_Java_DataflowV2

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run PostCommit_Java_Dataflow

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@youngoli

Copy link
Copy Markdown
ContributorAuthor

Run Java PostCommit

@youngoli

youngoli commented Apr 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Resolved:
Dataflow Java Post Commit Tests - All bugs on this have been addressed and determined to be non-release blocking. (BEAM-14252)
Dataflow V2 Java Post Commit Tests - Same as above, resolved with BEAM-14252.
Java SDK Post Commit Tests - I forgot to rerun this, but all its failures were covered by BEAM-14252 so it should be resolved now. Will double-check once it's done running.
Java PreCommit - Fixed with cherry-pick #17295.

@youngoliyoungoli closed this Jun 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@youngoli