Uh oh!
There was an error while loading. Please reload this page.
[BEAM-14277] Disables Spanner change streams tests - #17346
Merged
Conversation
Disables the Spanner change streams tests for now. They are currently failing because they are using the default auto-scaling algorithm (throughput-based), which is not supported for change streams. We decided to disable the tests here, because we can not change the autoscaling algorithm without adding the dependency of dataflow into the tests module. Since we are soon re-enabling auto-scaling, we will also re-enable the tests when we submit the PR then.
asf-ci
commented
Apr 12, 2022
Can one of the admins verify this patch? |
2 similar comments
asf-ci
commented
Apr 12, 2022
Can one of the admins verify this patch? |
asf-ci
commented
Apr 12, 2022
Can one of the admins verify this patch? |
thiagotnunes
commented
Apr 12, 2022
ContributorAuthor
R: @emilymye |
thiagotnunes
commented
Apr 12, 2022
ContributorAuthor
R: @pabloem |
emilymye
approved these changes
Apr 12, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…am/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamIT.java Co-authored-by: emily <emilyye@google.com>
…am/sdk/io/gcp/spanner/changestreams/it/SpannerChangeStreamTransactionBoundariesIT.java Co-authored-by: emily <emilyye@google.com>
thiagotnunes
commented
Apr 12, 2022
ContributorAuthor
Run Java PostCommit |
emilymye
commented
Apr 12, 2022
Contributor
Run Java PreCommit |
2 similar comments
pabloem
commented
Apr 12, 2022
Member
Run Java PreCommit |
pabloem
commented
Apr 12, 2022
Member
Run Java PreCommit |
Contributor
Feel confident that the precommit failure is not related, and this is sickbaying tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the Spanner change streams tests for now. They are currently failing because they are using the default auto-scaling algorithm (throughput-based), which is not supported for change streams.
We decided to disable the tests here, because we can not change the autoscaling algorithm without adding the dependency of dataflow into the tests module. Since we are soon (#17200) re-enabling auto-scaling, we will also re-enable the tests when we submit the PR then.