Skip to content

[BEAM-14321] SQL passes Null for Null aggregates - #17387

Merged
apilloud merged 1 commit into
apache:masterfrom
apilloud:nullagg
Apr 22, 2022
Merged

[BEAM-14321] SQL passes Null for Null aggregates#17387
apilloud merged 1 commit into
apache:masterfrom
apilloud:nullagg

Conversation

@apilloud

Copy link
Copy Markdown
Member

Pass null through accumulators that only have null inputs


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@apilloud

Copy link
Copy Markdown
MemberAuthor

R: @ibzib
Passes internal ZetaSQL tests, additional tests are now passing.

@apilloud

Copy link
Copy Markdown
MemberAuthor

R: @TheNeuralBit

@apilloud
apilloud merged commit 5cae610 into apache:masterApr 22, 2022
@apilloud
apilloud deleted the nullagg branch April 22, 2022 16:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@apilloud@TheNeuralBit