Skip to content

[BEAM-14446] Update some docs to point to GitHub issues - #17594

Merged
aijamalnk merged 9 commits into
apache:masterfrom
damccorm:users/damccorm/doc-updates
Jun 2, 2022
Merged

[BEAM-14446] Update some docs to point to GitHub issues#17594
aijamalnk merged 9 commits into
apache:masterfrom
damccorm:users/damccorm/doc-updates

Conversation

@damccorm

@damccormdamccorm commented May 9, 2022

Copy link
Copy Markdown
Contributor

This PR updates all the docs we can update before migrating to GitHub issues. There are a number of links that will need to be updated after this PR completes to point to a newly migrated GitHub issue, but that can't happen until we run the migration tool.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@codecov

codecovBot commented May 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17594 (7735050) into master (57f3705) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #17594 +/- ##
=======================================
Coverage 74.01% 74.01% =======================================
Files 695 695 Lines 91868 91872 +4 =======================================
+ Hits 67997 68001 +4 
Misses 22625 22625 Partials 1246 1246 
FlagCoverage Δ
go50.48% <ø> (ø)
python83.76% <ø> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/go/pkg/beam/coder.go54.95% <ø> (ø)
...ks/python/apache_beam/runners/worker/sdk_worker.py88.94% <0.00%> (-0.16%)⬇️
sdks/python/apache_beam/transforms/util.py96.06% <0.00%> (-0.16%)⬇️
...hon/apache_beam/runners/worker/bundle_processor.py93.54% <0.00%> (-0.13%)⬇️
sdks/python/apache_beam/io/gcp/bigquery.py64.84% <0.00%> (-0.12%)⬇️
sdks/python/apache_beam/ml/inference/api.py90.00% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/pytorch.py0.00% <0.00%> (ø)
...thon/apache_beam/ml/inference/sklearn_inference.py92.68% <0.00%> (ø)
sdks/python/apache_beam/ml/inference/base.py92.90% <0.00%> (+0.20%)⬆️
sdks/python/apache_beam/io/localfilesystem.py91.72% <0.00%> (+0.75%)⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f3705...7735050. Read the comment docs.

@damccorm
damccorm marked this pull request as ready for review May 27, 2022 17:27
@damccorm

Copy link
Copy Markdown
ContributorAuthor

R: @aijamalnk

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@aijamalnkaijamalnk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's send a heads up email as a new thread on the dev list before merging? The last update didn't get any responses, so I wonder if people muted the thread.

harder to roll back part of a commit.
* Commit messages should tag JIRAs and be otherwise descriptive.
It should later not be necessary to find a merge or first PR commit to find out what caused a change.
* Commit messages should be descriptive. It should later not be necessary to find a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should commit messages also reference the issue number?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - updated to this

@damccorm

Copy link
Copy Markdown
ContributorAuthor

LGTM. Let's send a heads up email as a new thread on the dev list before merging? The last update didn't get any responses, so I wonder if people muted the thread.

Done!

@damccorm

Copy link
Copy Markdown
ContributorAuthor

Run Java PreCommit

@damccorm

Copy link
Copy Markdown
ContributorAuthor

Run Python_PVR_Flink PreCommit

@aijamalnk
aijamalnk merged commit 3d5d145 into apache:masterJun 2, 2022
@damccorm
damccorm deleted the users/damccorm/doc-updates branch June 2, 2022 21:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@damccorm@asf-ci@aijamalnk