Skip to content

[BEAM-14447] Revert "Merge pull request #17517 from [BEAM-14383] Improve "FailedRo… - #17601

Merged
pabloem merged 1 commit into
apache:masterfrom
pabloem:rb-pr-17517
May 10, 2022
Merged

[BEAM-14447] Revert "Merge pull request #17517 from [BEAM-14383] Improve "FailedRo…#17601
pabloem merged 1 commit into
apache:masterfrom
pabloem:rb-pr-17517

Conversation

@pabloem

Copy link
Copy Markdown
Member

…ws" errors returned by beam.io.WriteToBigQuery"

This reverts commit 3587820.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

…iledRows" errors returned by beam.io.WriteToBigQuery"
This reverts commit 3587820.
@pabloem

Copy link
Copy Markdown
MemberAuthor

Run Python 3.8 PostCommit

@pabloem

Copy link
Copy Markdown
MemberAuthor

r: @TheNeuralBit
fyi: @Firlej

I'll roll this forward along with PR 17584

@TheNeuralBitTheNeuralBit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheNeuralBitTheNeuralBit changed the title Revert "Merge pull request #17517 from [BEAM-14383] Improve "FailedRo…[BEAM-14447] Revert "Merge pull request #17517 from [BEAM-14383] Improve "FailedRo…May 10, 2022
@pabloem

Copy link
Copy Markdown
MemberAuthor

Run Python 3.8 PostCommit

1 similar comment
@pabloem

Copy link
Copy Markdown
MemberAuthor

Run Python 3.8 PostCommit

@pabloem

Copy link
Copy Markdown
MemberAuthor

Run Python 3.8 PostCommit

@codecov

codecovBot commented May 10, 2022

Copy link
Copy Markdown

Codecov Report

Merging #17601 (abf488e) into master (5c21fbc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #17601 +/- ##
==========================================
- Coverage 73.96% 73.95% -0.02% 
==========================================
Files 693 693 Lines 91716 91716 ==========================================
- Hits 67837 67826 -11 - Misses 22630 22641 +11 
Partials 1249 1249 
FlagCoverage Δ
python83.70% <100.00%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py63.98% <100.00%> (+0.11%)⬆️
.../python/apache_beam/testing/test_stream_service.py88.09% <0.00%> (-4.77%)⬇️
...python/apache_beam/runners/worker/worker_status.py78.26% <0.00%> (-1.45%)⬇️
...che_beam/runners/interactive/interactive_runner.py89.20% <0.00%> (-1.44%)⬇️
...eam/runners/portability/fn_api_runner/execution.py92.44% <0.00%> (-0.65%)⬇️
sdks/python/apache_beam/transforms/combiners.py93.05% <0.00%> (-0.39%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c21fbc...abf488e. Read the comment docs.

@pabloem
pabloem merged commit 2f1117b into apache:masterMay 10, 2022
@pabloem
pabloem deleted the rb-pr-17517 branch May 10, 2022 21:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pabloem@TheNeuralBit